From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix step-over-syscall.exp matching regexp for $bpnum.$locno matching
Date: Mon, 21 Nov 2022 21:15:06 +0100 [thread overview]
Message-ID: <c29addcc6e580cd1a1fb8876bf445a8c81d7c71f.camel@skynet.be> (raw)
In-Reply-To: <db263e5e-55d1-a323-b4f1-6c1413fd843f@simark.ca>
On Mon, 2022-11-21 at 07:58 -0500, Simon Marchi wrote:
>
> On 11/20/22 18:36, Philippe Waroquiers via Gdb-patches wrote:
> > step-over-syscall.exp has some specific tests for gdbserver.
> > The regexp matching breakpoint hit must take the added locno into account.
> >
> > Test re-run in 3 modes (normal, native-gdbserver and native-extended-gdbserver).
> > ---
> > gdb/testsuite/gdb.base/step-over-syscall.exp | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/gdb/testsuite/gdb.base/step-over-syscall.exp b/gdb/testsuite/gdb.base/step-over-syscall.exp
> > index 788f6e3f5d0..3160900ad83 100644
> > --- a/gdb/testsuite/gdb.base/step-over-syscall.exp
> > +++ b/gdb/testsuite/gdb.base/step-over-syscall.exp
> > @@ -321,6 +321,7 @@ proc step_over_syscall { syscall } {
> > # "on" or "off".
> >
> >
> > proc break_cond_on_syscall { syscall follow_fork detach_on_fork } {
> > + global bkptno_numopt_re
> > with_test_prefix "break cond on target : $syscall" {
> > set testfile "step-over-$syscall"
> >
> >
> > @@ -368,12 +369,12 @@ proc break_cond_on_syscall { syscall follow_fork detach_on_fork } {
> > if { $detach_on_fork == "off" } {
> > gdb_test "inferior 1"
> > gdb_test "break marker" "Breakpoint.*at.*"
> > - gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, marker \\(\\) at.*" \
> > + gdb_test "continue" "Continuing\\..*Breakpoint $bkptno_numopt_re, marker \\(\\) at.*" \
> > "continue to marker"
> > }
> > } else {
> > gdb_test "break marker" "Breakpoint.*at.* file .*${testfile}.c, line.*"
> > - gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, marker \\(\\) at.*" \
> > + gdb_test "continue" "Continuing\\..*Breakpoint $bkptno_numopt_re, marker \\(\\) at.*" \
>
> I would suggest using the $::bkptno_numopt_re form (and removing the
> global declaration), that makes it clear on use that this is a global
> variable. With that fixed:
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> Simon
Pushed after implementing the suggestion above.
Thanks for the review.
Philippe
prev parent reply other threads:[~2022-11-21 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 23:36 Philippe Waroquiers
2022-11-21 12:58 ` Simon Marchi
2022-11-21 20:15 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c29addcc6e580cd1a1fb8876bf445a8c81d7c71f.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).