From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 339C23858CDA for ; Fri, 22 Dec 2023 04:42:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 339C23858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 339C23858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703220133; cv=none; b=qaLV/eiePuvy8e1Vfaeg/jNKy+mXYGzIsMyKC9MAlEpHvN/h8QVn0reyXkV5ueHPKJABCTICIjytMrKSn3T+ReoY3lwP2aTZblh3Hd0VG2REbAOE0ZuoALGyyj72hmjRKzXCZisR/vsGRM/HZFLw13VyCeO3rd2s1mRxFEK0eO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703220133; c=relaxed/simple; bh=JrJXPw+XmrvzPzRAmEgtdLI5FnVDVTAiJRfTjKjBQB4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JmnFE5VSAPz32y3/l5AAnz+87SG2yqsedPqJNLGYpAajf8jMR7h8GtHvntYb3oYiWEAHcqPqW0e7AzY7/nptXrGd1oTp8IaXJDsZ/vMbHQd4hzQ/DpG80vKsFmPvLXCbg0ioHDK/PGwHe7q6GjAOBWuR2K8blXBLWBkDSWPVjiM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703220131; bh=JrJXPw+XmrvzPzRAmEgtdLI5FnVDVTAiJRfTjKjBQB4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=F4/yx6fMCtv5kI10+z6493QSYX9CabUjtB6MVCRFcY89tBBYzK48922uqShsMghyt a3icoNX9dFZnc3n6Dl2DBvrJiIb5L/LtYquHXX9oFdVf8XMpQvi1ThMUDsOwcWk+0p WOSbP278bf1BQIDwuC5tRvEmHKBU6j2AP1JHWJbY= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C9D811E091; Thu, 21 Dec 2023 23:42:11 -0500 (EST) Message-ID: Date: Thu, 21 Dec 2023 23:42:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24/26] gdbserver: return tracked register status in regcache_raw_read_unsigned Content-Language: en-US To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <232ee024f5b957a07c047c724d7065074da1ef34.1677582745.git.tankut.baris.aktemur@intel.com> From: Simon Marchi In-Reply-To: <232ee024f5b957a07c047c724d7065074da1ef34.1677582745.git.tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-28 06:28, Tankut Baris Aktemur via Gdb-patches wrote: > In regcache_raw_read_unsigned, we unconditionally return REG_VALID as > the register status. This does not seem right, since the register may > in fact be in another state, such as REG_UNAVAILABLE. Return the > tracked status. > --- > gdbserver/regcache.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc > index 32f0e1109e6..4533e9e9b12 100644 > --- a/gdbserver/regcache.cc > +++ b/gdbserver/regcache.cc > @@ -451,7 +451,7 @@ regcache_raw_read_unsigned (struct regcache *regcache, int regnum, > *val = 0; > collect_register (regcache, regnum, val); > > - return REG_VALID; > + return regcache->get_register_status (regnum); > } > > #ifndef IN_PROCESS_AGENT LGTM. You can push it right away, if you think it makes sense. Approved-By: Simon Marchi Simon