Re: [PATCH] Make dtor of mapped_index_base virtual

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2017-12-30 13:21, Павел Крюков wrote:
> gdb/Changelog:
> 2017-12-30  Pavel I. Kryukov  <kryukov@frtk.ru>
> 
>        * dwarf2read.c (mapped_index_base): Make dtor virtual
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 8555b55..fc4c1b3 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,7 @@
> +2017-12-30  Pavel I. Kryukov  <kryukov@frtk.ru>
> +
> +       * dwarf2read.c (mapped_index_base): Make dtor virtual
> +
>  2017-12-28  Simon Marchi  <simon.marchi@polymtl.ca>
> 
>         * target.h (enum target_object) <TARGET_OBJECT_HPUX_UREGS,
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index 484cbce..3ac4380 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -272,7 +272,7 @@ struct mapped_index_base
> 
>    /* Prevent deleting/destroying via a base class pointer.  */
>  protected:
> -  ~mapped_index_base() = default;
> +  virtual ~mapped_index_base() = default;
>  };
> 
>  /* A description of the mapped index.  The file format is described in
> --
> 2.7.4

Hi Pavel,

Can you clarify what you are trying to fix/improve with this patch?  
Since the goal is that we don't delete through a pointer of this class, 
does the destructor need to be virtual (not that it would hurt 
anything)?  Do you get a build error or something?

Simon