From: Pedro Alves <palves@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gdb-patches@sourceware.org
Subject: Re: [COMMITTED PATCH][PR gdb/25939] Move push_target call earlier in procfs.c
Date: Mon, 22 Jun 2020 11:19:28 +0100 [thread overview]
Message-ID: <c2f3e180-55da-a688-2b2f-4ef47c6735ff@redhat.com> (raw)
In-Reply-To: <yddk100pe85.fsf_-_@CeBiTec.Uni-Bielefeld.DE>
On 6/21/20 5:37 PM, Rainer Orth wrote:
> Hi Pedro,
>
>> On 6/19/20 1:36 PM, Rainer Orth wrote:
>>>> On 6/18/20 3:55 PM, Pedro Alves via Gdb-patches wrote:
>>
>>>> Your push_target fix is still necessary, FAOD.
>>>
>>> Should I push it as is (with an appropriate description, of course) or
>>> would the code change need a comment, too?
>>
>> It's fine without a comment. I think you can remove the
>> push_target call from procfs_init_inferior at the same time,
>> too, as that one becomes unnecessary. Basically make the fix be
>> about moving the push_target call earlier.
>
> that works just fine. Here's what I've committed after testing both
> pathes together on amd64-pc-solaris2.11.
I've committed mine now.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-06-22 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 14:21 Unbreaking gdb on Solaris post-multitarget [PR 25939] Rainer Orth
2020-06-16 19:16 ` Pedro Alves
2020-06-17 14:45 ` Rainer Orth
2020-06-18 14:55 ` Pedro Alves
2020-06-18 15:51 ` Pedro Alves
2020-06-19 12:36 ` Rainer Orth
2020-06-19 13:55 ` Pedro Alves
2020-06-21 16:37 ` [COMMITTED PATCH][PR gdb/25939] Move push_target call earlier in procfs.c Rainer Orth
2020-06-22 10:19 ` Pedro Alves [this message]
2020-06-17 15:43 ` Unbreaking gdb on Solaris post-multitarget [PR 25939] Tom Tromey
2020-06-17 17:07 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2f3e180-55da-a688-2b2f-4ef47c6735ff@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).