From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 16CDE385B834 for ; Mon, 22 Jun 2020 10:19:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 16CDE385B834 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-eJwKVxRRMJOYcgnlf1JDxg-1; Mon, 22 Jun 2020 06:19:33 -0400 X-MC-Unique: eJwKVxRRMJOYcgnlf1JDxg-1 Received: by mail-wr1-f71.google.com with SMTP id d6so10625921wrn.1 for ; Mon, 22 Jun 2020 03:19:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VEWpGsoo/OKlA/UqjgAVcL9rR1u9wx97zrVhvo92t9I=; b=h+yoSz94+64C//JAMXx5aYOrhljfAdu1VcXE4rPSQCh/Zy1HgsUVLY5remyIGaimfh J8t0lGbhzGFue+8QB1K7+sHzsRcybgmXaqWgDhqnNC9whd5Gzy8DtpMULQDN0vdCeRP/ uCtDOb/1GWmxp9Nj4aITEmwIt15XDsGQM1FOt59/pJFePL5x3BpFyDJjQ7bYh1nlQPyy VxRo8RL0mKHan7wXjPIgWlBWkZoqIDv0htKbVu72/AcvqhNzf6FNcGNVM7P2qK4PkgBm 4JZMuph8tTs3ZYaW6gOtRCbf3VLFEh/aeSmI8PXmIVUFNvWj7dm0sd/QW8xWAfh+FTdX Vq1A== X-Gm-Message-State: AOAM5309ByjPlT00VCOIYIKRVlqog6Y5V1V+hrRnsXe0lSgMqyXowQ2n xhUmryXYEbeTjLi/BdZzZLM8B1HZPd6qWtXoSYuuO/5eoPh+afLPCcbwHm7DZ8LrXzPZfm4K10R 8kzgXhuOH3+r+QqZTkpEwSw== X-Received: by 2002:a05:600c:2f17:: with SMTP id r23mr16987134wmn.167.1592821172470; Mon, 22 Jun 2020 03:19:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8kbfq/yOTKFbugvBzyeQo4ere9EYDUdWCgWZhhkQ0df7S/KYH6YbXGaSA+Mqv18uG8rFv8w== X-Received: by 2002:a05:600c:2f17:: with SMTP id r23mr16987125wmn.167.1592821172315; Mon, 22 Jun 2020 03:19:32 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id w17sm17963904wra.42.2020.06.22.03.19.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 03:19:31 -0700 (PDT) Subject: Re: [COMMITTED PATCH][PR gdb/25939] Move push_target call earlier in procfs.c To: Rainer Orth References: <7fb790ae-61a9-a6a3-3b87-74fcac400664@redhat.com> <0e3e81a9-a5de-42bc-7d58-094f2adca164@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 22 Jun 2020 11:19:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 10:19:37 -0000 On 6/21/20 5:37 PM, Rainer Orth wrote: > Hi Pedro, > >> On 6/19/20 1:36 PM, Rainer Orth wrote: >>>> On 6/18/20 3:55 PM, Pedro Alves via Gdb-patches wrote: >> >>>> Your push_target fix is still necessary, FAOD. >>> >>> Should I push it as is (with an appropriate description, of course) or >>> would the code change need a comment, too? >> >> It's fine without a comment. I think you can remove the >> push_target call from procfs_init_inferior at the same time, >> too, as that one becomes unnecessary. Basically make the fix be >> about moving the push_target call earlier. > > that works just fine. Here's what I've committed after testing both > pathes together on amd64-pc-solaris2.11. I've committed mine now. Thanks, Pedro Alves