From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by sourceware.org (Postfix) with ESMTPS id 215173834E47 for ; Thu, 26 May 2022 07:29:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 215173834E47 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YlmfyteAs07iLuzxUPfrCMygnqO8008pMFIGJs+fEIh55HQgkVKkaNOzlld229mws24rPA2uUDp5j7AeXRqs2Ag/HJqunnDX7lSGL9ZD0/ymM4Z+9VbkTUq9Z3Cuexi9rfSAVVh8OWLtdA4BicY+h4JOm79Ca2Y9P3jKzuAS658SgFisRlKzgymsxMaGJwhYOCwRRnSy8vtx6ZNUlTT1jpnqOHcqbiQ1dqyjKK+zpWosyUztmzHcIta/+AHBZwJoN0kyAXhGAdUfhayYNpWWfaoyQzibupRCFm9ZBWjwT74U5TtVlDNktyHaA7tN4c6V469nQL34Uig8uSHji8HV7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OrtE5t5iFYCgamqjBqXMkr/ZmvGfz81OI4O/KN7Edtc=; b=XBd8z2D9YO/ztjLBHV63psdMvVx4Uwa6OqOM6/IthLs2/FtrtBbvBezVUK5rk7LYYSD20uLn4LqAzaxVwu7+x73QyKjYai23Fd0NXohYg43LXLF2Z49HmMfrX5HU38VJZb15JMudVTD0eHxOt58vTMlFvgxdBPwHQOfe7qtBgsoH7ZXkerXw5B7AtRiB1a31kDKophDmkGn/NiN3U6WQLTo4JqOYn4cr0j1gy88kSmsC4Z5mQcOhZ18mykcSN34bwWhRxIKJ4Bcc+7TgqJhidZJPdeHTjg0qWlV6VkQ24zub0cjhSdTdstQf8x2Jj7jU1QJSXKJG3luVfz/vIxAzlg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB8PR06CA0034.eurprd06.prod.outlook.com (2603:10a6:10:100::47) by PA4PR08MB7458.eurprd08.prod.outlook.com (2603:10a6:102:2a5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Thu, 26 May 2022 07:29:49 +0000 Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::16) by DB8PR06CA0034.outlook.office365.com (2603:10a6:10:100::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 07:29:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 07:29:49 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Thu, 26 May 2022 07:29:49 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 217091a2fda2a2cb X-CR-MTA-TID: 64aa7808 Received: from 61f4630207a5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BEF935DD-962E-41A9-B961-8FC5487F7C63.1; Thu, 26 May 2022 07:29:42 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 61f4630207a5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 07:29:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U6XtWvIcDSktM0Xd1FGw6RCTC5B1D35yt2IvU1vzU16iuH8ePMw8nMTEgJRHQACGSddRfYzjDSUqDKOWKh5m6s5eKoVJaa8yOu761e1k3esAX+Vk9zyADTT0UQbpue40KYhFyu//wxBsAzEw/WfEKK5/GzoY0UclI656QvRtPjYzzBJ40YVmAz4PwJGIn6kl99YbpukSm+ZEHV0slyjc1apSt5ecnc0atLCgmlaucciZUsAAoexXSbl8N0Nj/UX/K/Km1DM9GhhrqOKOSqY5PTL5yB7DfV+25iZtAh38sB7q2PX5mBs+vjeyET3NiTfKqjw36YH3m89BMccIkLePgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OrtE5t5iFYCgamqjBqXMkr/ZmvGfz81OI4O/KN7Edtc=; b=CK6xsptM9AMamuAAf8htQU4ngCZYLPFznOJDC8DJhDt3xO0SGH/+mb0bmRvfSVzNNg+aTw+JKvJDmOaPVXzUhZjx0flmKi2x3bQC1Pt1sHlap3JVyUa/7lunmbjwnI9AQ9K7h4+FxG/KqvfXHi/YqbZiL/y79h+eaLixb3Q1lomyeLaiJW7SQ0rZlL0sNvdQlGEgJ6n2px2h+YBqMLZx0h65SFyMP9P2waQuj9dG8TqQkQMr76OEWxy6PT3NehGg4gE0YR6vQTcis4r4BJsAVZTnxN8dNESkOK6vI1DhIbYnGqEhWSBbE1I636CPHp1RpNkVn05r7ZZv3ol/6CKypQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS4PR08MB7831.eurprd08.prod.outlook.com (2603:10a6:20b:51b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 07:29:41 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5273.023; Thu, 26 May 2022 07:29:41 +0000 Message-ID: Date: Thu, 26 May 2022 08:29:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] gdb/arm: Cleanup: use hex for offsets Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn SVENSSON References: <20220525151240.GA11828@gnbcxd0114.gnb.st.com> From: Luis Machado In-Reply-To: <20220525151240.GA11828@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0025.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::12) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7dd226c3-6829-42a7-4726-08da3ee98481 X-MS-TrafficTypeDiagnostic: AS4PR08MB7831:EE_|DBAEUR03FT036:EE_|PA4PR08MB7458:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: s6CFyyMbPPhcLQT06+34ppGJASzWn/ULKHcVqWw8Yw7m7rsDeqOAsd108bBLdSJC2qs3+y7FSQArhPDsl1pR6Xj+yT+yAkgehgkM3oy8kzKcBpT28iDZqR4uriblf6j6vIQ4yR6NAuvYQ9a7/MKAZCmvY94vf2HeWztcvQvZya1URYIL/D8Bm9K6kestgz7NasB/2KS3P/P5z5BuRW9kDpBSMXGwcjlVJ2kAxeN6fifddjtxJwT159PYD/L8Ak3zj/skEofehRaQUja9urM2Rx2A6CMpOWhKeCk6ccsPDIy1mPAH4G6L0T60d8FuErfFXz5nk5vH0dyyhhForpcYiruTlgwzVW8MGROQx/Fhg/rKbydU4IdLq13ACvlpLpaHyu7QDDq1UgYldtaNVluPw3TrrDRNrHYkR8bbzo+Gjnf4d+j9x6sd/CGjBdrVw1vp6tcKW5yb9kG9CaBM9GxBXQ7ko2567lyr5L0CdYaqE/eXzJq/d3VuMXJgixfCZLqCNDzMnN1XreqWQ5iU9KZxW4R8Zd+xEwm59KKgwv76Q+eueHzOUlylC7I8CoP0D/py9cfJU/ghg4k6bzUwV4sdtQl/my0jn/5AB16920pyyH/iAX6DdvtyOhJdVJyHSyDUtkFcWQz3uGDLiUPOCcd2jhx3kGxwBFrdxaMo/12HAHpz7b4fQlEv9+7vi4Gdg0IF0jTEkIws4Ti3Xa/dUIfbe2yhjcZ0GrbtHYl731uveqY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(83380400001)(53546011)(6506007)(26005)(2616005)(6512007)(8936002)(66556008)(86362001)(5660300002)(36756003)(66946007)(66476007)(31696002)(2906002)(508600001)(44832011)(4326008)(38100700002)(6486002)(6666004)(31686004)(8676002)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7831 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3586ff9e-cb1a-4b52-3293-08da3ee97f36 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1JsSNElKt7KDBFda30EA9BtavFl+jz8X+6TxDgUtgCVONeGhkQ4/xO6AVxC7RkaFSbMiBt0Hhn/Soeu3gpfln8fA3dzI2DAq+XMPS2F11HFaoSdvOHjBKis6mMD85RTYqvIT0M1wOQz0pku+kPcEBbDAS/B7Of2mWEh+vbWcuQAK/Naf0L91ljkeU6ROyZehjcwiSaumI4b7W6MjFnh2klgU9vm+NDn9uUrRGTvbKC5tGpOGfbL8PfgrsuvrjMkoc0LSD198rMw9ELhmcKbDbujQs0FGKQaSWdz227gV3Pxb6bzUrOQAH0ow3/2MwElGnNSk2WXSaVlYOYMTtJSgY3UY91G7tdYwUQK7uFPvYgmG4jUCPFU205Y6A0lCqNTqibqxos16o5u0BGdhqscfsogE00HBrbI1zmcZk4jGDKNJtMCR+1NTEO37CXq30G1MTcM76b1UIRGKIeps+5lQqV6ZSWroEmLVPHe1bEJ+xt4nMim3alZwZujKlImxC40J0w5eGqwBbxJeTBp4pXHS2k/yMTnDjxCgWsHPTwnIX2qhK3KGs3CPu/oePGj/paBa/eg/vwbykAlvNYgN1VSlL4PO9RJLMrF742rktaewxdwvJYG02i8u0SF7yy6R/DHfNeMgwq+3PEkkDe7hLThIWXVRxIeQtc9K+7ZHTWcyMusVrMheLgoSNYJCiiODF7DqjWjFvn6GngLiWaOWQ0PdBA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(70206006)(31686004)(83380400001)(2616005)(26005)(6512007)(2906002)(186003)(31696002)(70586007)(82310400005)(336012)(81166007)(47076005)(8676002)(53546011)(4326008)(5660300002)(6506007)(8936002)(6486002)(356005)(508600001)(44832011)(36756003)(36860700001)(316002)(6666004)(40460700003)(86362001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 07:29:49.7713 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd226c3-6829-42a7-4726-08da3ee98481 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7458 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 07:29:53 -0000 On 5/25/22 16:12, Yvan Roux wrote: > Hi, > > Changed offset from decimal to hex to match architecture reference > manual terminology and keep coherency with the rest of the code. > > Signed-off-by: Torbj�rn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 49664093f00..21cd80c5fcc 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -3438,13 +3438,13 @@ arm_m_exception_cache (struct frame_info *this_frame) > "B1.5.6 Exception entry behavior" in > "ARMv7-M Architecture Reference Manual". */ > cache->saved_regs[0].set_addr (unwound_sp + sp_r0_offset); > - cache->saved_regs[1].set_addr (unwound_sp + sp_r0_offset + 4); > - cache->saved_regs[2].set_addr (unwound_sp + sp_r0_offset + 8); > - cache->saved_regs[3].set_addr (unwound_sp + sp_r0_offset + 12); > - cache->saved_regs[ARM_IP_REGNUM].set_addr (unwound_sp + sp_r0_offset + 16); > - cache->saved_regs[ARM_LR_REGNUM].set_addr (unwound_sp + sp_r0_offset + 20); > - cache->saved_regs[ARM_PC_REGNUM].set_addr (unwound_sp + sp_r0_offset + 24); > - cache->saved_regs[ARM_PS_REGNUM].set_addr (unwound_sp + sp_r0_offset + 28); > + cache->saved_regs[1].set_addr (unwound_sp + sp_r0_offset + 0x04); > + cache->saved_regs[2].set_addr (unwound_sp + sp_r0_offset + 0x08); > + cache->saved_regs[3].set_addr (unwound_sp + sp_r0_offset + 0x0C); > + cache->saved_regs[ARM_IP_REGNUM].set_addr (unwound_sp + sp_r0_offset + 0x10); > + cache->saved_regs[ARM_LR_REGNUM].set_addr (unwound_sp + sp_r0_offset + 0x14); > + cache->saved_regs[ARM_PC_REGNUM].set_addr (unwound_sp + sp_r0_offset + 0x18); > + cache->saved_regs[ARM_PS_REGNUM].set_addr (unwound_sp + sp_r0_offset + 0x1C); > > /* Check EXC_RETURN bit FTYPE if extended stack frame (FPU regs stored) > type used. */ > @@ -3499,7 +3499,7 @@ arm_m_exception_cache (struct frame_info *this_frame) > /* If bit 9 of the saved xPSR is set, then there is a four-byte > aligner between the top of the 32-byte stack frame and the > previous context's stack pointer. */ > - if (safe_read_memory_integer (unwound_sp + sp_r0_offset + 28, 4, byte_order, &xpsr) > + if (safe_read_memory_integer (unwound_sp + sp_r0_offset + 0x1C, 4, byte_order, &xpsr) > && (xpsr & (1 << 9)) != 0) > arm_cache_set_active_sp_value (cache, tdep, > arm_cache_get_prev_sp_value (cache, tdep) + 4); Thanks. This is OK with the long lines fixed. The last one is going over the limit of 80 cols.