From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43723 invoked by alias); 28 Nov 2017 00:42:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43711 invoked by uid 89); 28 Nov 2017 00:42:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Nov 2017 00:42:48 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7B2B25D68A for ; Tue, 28 Nov 2017 00:42:47 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4560360C91; Tue, 28 Nov 2017 00:42:47 +0000 (UTC) Subject: Re: [PATCH 32/40] Make "break foo" find "A::foo", A::B::foo", etc. [C++ and wild matching] To: Pedro Alves , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-33-git-send-email-palves@redhat.com> <024edecc-7bfa-08a4-de46-3536297f0654@redhat.com> <943402c5-0bbb-8ff7-66e3-5522256fbc1e@redhat.com> <0a9b24ee-e9c0-7c24-b44b-12d0130a2d38@redhat.com> From: Keith Seitz Message-ID: Date: Tue, 28 Nov 2017 00:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <0a9b24ee-e9c0-7c24-b44b-12d0130a2d38@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00713.txt.bz2 On 11/27/2017 04:21 PM, Pedro Alves wrote: >> >> Simple is good! > > :-) If you look at v2, you'll notice that that sentence was completely > rewritten though. :-P > Ha ha ha... That's what I get for linear email processing! >> If I've read my catch-up mail correctly, there's been a change of plan here. > > Yup. I've implemented your suggestion and posted it today: > https://sourceware.org/ml/gdb-patches/2017-11/msg00689.html > > Actually, I've just now posted a v2.1 to fix "save breakpoints": > https://sourceware.org/ml/gdb-patches/2017-11/msg00709.html > so make sure to read that one instead. > > So if you could skim that, and let me know if I've addressed > everything, I'd appreciate it. Absolutely. Please ignore any irrelevant replies from me. I'll eventually get to the right patch. [Besides, I could use the review practice!] Keith