From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id EDD44383E81D for ; Fri, 15 May 2020 20:07:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EDD44383E81D Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-FS83kNHjM_yHsOUpOa58DA-1; Fri, 15 May 2020 16:07:30 -0400 X-MC-Unique: FS83kNHjM_yHsOUpOa58DA-1 Received: by mail-ed1-f69.google.com with SMTP id t5so1386854edc.1 for ; Fri, 15 May 2020 13:07:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gK12OYmwfIwg3PpZP1gxxCNANIfEzKf+qGTtoprpWos=; b=bjfXA31tE8EVSMy3lWwtM71pABz0qY6Owd6CGI9/NXTSdCu8JwPE/rxrVjmVg4a/+U sSSlttC52nSvxU0ctV9yRdgPeU5oE+kvtdKwsUdLAlqcvfYHQ1iP+y8QSm8+v+XlSOU/ HWu0nEvO+wCqF71r8Rq491tCSMtwy7tesRTrOL57WJbaNcPixM35t0j4iGX3Owyz8f6O sP/EFlyvrHdF3+0nD7h1lGyohUBoE+7LmHu8y34Ue479NZC9vbsUBRTZfrQ/jMPOmkRN FcP2+rR70DuJZK0DIYxGRbt2oFh/ohc8eRPdLnU2fVza4QWvusu8TGccstC165H/FQZI i04w== X-Gm-Message-State: AOAM531p190DpwweKMBOypZ4zl0ioLflJwqk6rflaAUvhZS1tqAljpcL QzSPyH2VYiqmg0Xvv8ktd8X/Xs8WC3JNkvKiewwa4Qh7h1OmpLV1eN52LvEzaT8ycgOx0eWks/u dy7KOoKC3CXcLftYxMZ/1JQ== X-Received: by 2002:a50:9f4a:: with SMTP id b68mr4580932edf.108.1589573249310; Fri, 15 May 2020 13:07:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdcL3W1u8t9kyHpp/xxwO5DBUiHnECwGGC0ZoYCgQal2nCieokIxJf67nQl7otj89zzR5BKA== X-Received: by 2002:a50:9f4a:: with SMTP id b68mr4580916edf.108.1589573249140; Fri, 15 May 2020 13:07:29 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id h14sm283028edv.34.2020.05.15.13.07.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2020 13:07:28 -0700 (PDT) Subject: Re: [PATCH 2/2] gdb/testsuite: add inferior arguments test To: Simon Marchi , gdb-patches@sourceware.org References: <1190e73a-8f10-dc6d-4d59-b9a2929530ad@simark.ca> <20200510155937.1064329-1-simon.marchi@efficios.com> <20200510155937.1064329-2-simon.marchi@efficios.com> Cc: Michael Weghorn From: Pedro Alves Message-ID: Date: Fri, 15 May 2020 21:07:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200510155937.1064329-2-simon.marchi@efficios.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 20:07:37 -0000 On 5/10/20 4:59 PM, Simon Marchi via Gdb-patches wrote: > +++ b/gdb/testsuite/gdb.base/inferior-args.c > @@ -0,0 +1,8 @@ > +#include > + > +int main(int argc, char **argv) { > + for (int i = 0; i < argc; i++) > + printf("[%d] %s\n", i, argv[i]); > + > + return 0; > +} Formatting. Also missing copyright header. > +standard_testfile .c > + > +if {[build_executable "failed to prepare" $testfile $srcfile debug] == -1} { > + return > +} > + > +clean_restart $binfile This seems unnecessary, since do_test already calls it. Otherwise, you can use prepare_for_testing here. > + > +proc do_test { method } { > + global binfile hex > + > + # The second arg is an empty string on purpose. > + set inferior_args { "first arg" "" "third-arg" } > + > + clean_restart $binfile Otherwise LGTM. Thanks, Pedro Alves