Re: [PATCH 1/4] Remove read_memory_string

[Simon Marchi <simark@simark.ca>]

On 2020-06-12 5:53 p.m., Tom Tromey wrote:
> @@ -6721,34 +6721,38 @@ ada_get_tsd_from_tag (struct value *tag)
>     The returned value is good until the next call.  May return NULL
>     if we are unable to determine the tag name.  */
>  
> -static char *
> +static gdb::unique_xmalloc_ptr<char>
>  ada_tag_name_from_tsd (struct value *tsd)

The comment above needs to be updated.

>  {
> -  static char name[1024];
>    char *p;
>    struct value *val;
>  
>    val = ada_value_struct_elt (tsd, "expanded_name", 1);
>    if (val == NULL)
>      return NULL;
> -  read_memory_string (value_as_address (val), name, sizeof (name) - 1);
> -  for (p = name; *p != '\0'; p += 1)
> +  gdb::unique_xmalloc_ptr<char> buffer;
> +  int err;
> +  if (target_read_string (value_as_address (val), &buffer, INT_MAX, &err) == 0
> +      || err != 0)
> +    return nullptr;
> +
> +  for (p = (char *) buffer.get (); *p != '\0'; p += 1)

This cast is unnecessary.  I'd also change `p += 1` for p++ or ++p.

The enclosing for loop should use braces, normally.

Simon