From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id DD6363840C0B
 for <gdb-patches@sourceware.org>; Sat, 13 Jun 2020 14:19:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DD6363840C0B
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 441D61E111;
 Sat, 13 Jun 2020 10:19:47 -0400 (EDT)
Subject: Re: [PATCH 1/4] Remove read_memory_string
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
References: <20200612215356.22145-1-tromey@adacore.com>
 <20200612215356.22145-2-tromey@adacore.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <c3677699-c36d-e2dd-9d2f-6347d837fdb6@simark.ca>
Date: Sat, 13 Jun 2020 10:19:46 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200612215356.22145-2-tromey@adacore.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jun 2020 14:19:48 -0000

On 2020-06-12 5:53 p.m., Tom Tromey wrote:
> @@ -6721,34 +6721,38 @@ ada_get_tsd_from_tag (struct value *tag)
>     The returned value is good until the next call.  May return NULL
>     if we are unable to determine the tag name.  */
>  
> -static char *
> +static gdb::unique_xmalloc_ptr<char>
>  ada_tag_name_from_tsd (struct value *tsd)

The comment above needs to be updated.

>  {
> -  static char name[1024];
>    char *p;
>    struct value *val;
>  
>    val = ada_value_struct_elt (tsd, "expanded_name", 1);
>    if (val == NULL)
>      return NULL;
> -  read_memory_string (value_as_address (val), name, sizeof (name) - 1);
> -  for (p = name; *p != '\0'; p += 1)
> +  gdb::unique_xmalloc_ptr<char> buffer;
> +  int err;
> +  if (target_read_string (value_as_address (val), &buffer, INT_MAX, &err) == 0
> +      || err != 0)
> +    return nullptr;
> +
> +  for (p = (char *) buffer.get (); *p != '\0'; p += 1)

This cast is unnecessary.  I'd also change `p += 1` for p++ or ++p.

The enclosing for loop should use braces, normally.

Simon