From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id B81E938EA2E1 for ; Thu, 20 Oct 2022 09:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B81E938EA2E1 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 15BE8300089; Thu, 20 Oct 2022 09:39:02 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Nick Clifton Cc: gdb-patches@sourceware.org Subject: [PATCH 35/40] sim/sh: Initialize some variables Date: Thu, 20 Oct 2022 09:32:40 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 09:39:05 -0000 Clang generates a warning if a variable may be used uninitialized on some cases ("-Wsometimes-uninitialized"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). The cause of this error, $(builddir)/sim/sh/ppi.c is generated from $(srcdir)/sim/sh/gencode.c. Clang will detect the variable res may be used uninitialized when used on some cases. Likewise, GCC generates a warning if a variable may be used uninitialized on some cases ("-Wmaybe-uninitialized"). GCC will detect variables res, res_grd, carry, overflow and greater_equal may be used uninitialized on some cases. Despite that GCC will not cause a build failure even when "--enable-werror" is specified, it would be better to fix this as well since the cause is in the same function. --- sim/sh/gencode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c index 5eb7caf2589..03979695b08 100644 --- a/sim/sh/gencode.c +++ b/sim/sh/gencode.c @@ -3257,8 +3257,8 @@ ppi_gensim (void) printf (" static char const u_tab[] = { 8, 10, 7, 5};\n"); printf ("\n"); printf (" int z;\n"); - printf (" int res, res_grd;\n"); - printf (" int carry, overflow, greater_equal;\n"); + printf (" int res = 0, res_grd = 0;\n"); + printf (" int carry = 0, overflow = 0, greater_equal = 0;\n"); printf ("\n"); printf (" switch (ppi_table[iword >> 4]) {\n"); -- 2.34.1