From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: remove SYMBOL_*_OPS macros
Date: Fri, 19 Jan 2024 15:30:13 -0500 [thread overview]
Message-ID: <c3a384cb-34a3-4f79-8a4f-3f5c7faaad3c@simark.ca> (raw)
In-Reply-To: <87o7dhl0bn.fsf@tromey.com>
On 1/19/24 12:06, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> Remove SYMBOL_BLOCK_OPS, SYMBOL_COMPUTED_OPS and SYMBOL_REGISTER_OPS, in
> Simon> favor of methods on struct symbol. More changes could be done here to
> Simon> improve the design and make things safer, but I just wanted to do a
> Simon> straightforward change to remove the macros for now.
>
> Thanks.
>
> Simon> + if (auto computed_ops = var->computed_ops ())
> Simon> + return computed_ops->read_variable (var, frame);
>
> This one spot uses auto, but no other change does.
> That seemed weird. Normally I wouldn't mention it but I also noticed:
I initially used auto everywhere (kinda used to that now, because of
other projects), but then reverted it because in GDB so far we prefer
not to do that. I missed that spot.
>
> Simon> + if (framefunc != nullptr)
> Simon> + {
>
> Looks like the wrong indentation here.
Will fix and send a v2, thanks.
Simon
prev parent reply other threads:[~2024-01-19 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 16:31 Simon Marchi
2024-01-19 17:06 ` Tom Tromey
2024-01-19 20:30 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3a384cb-34a3-4f79-8a4f-3f5c7faaad3c@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).