From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BC9B43858C2A for ; Fri, 19 Jan 2024 20:30:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC9B43858C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BC9B43858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705696217; cv=none; b=GHy6Q8gqTmJU1irNFfsrnJZFn+xqIRMYQyADTgQEZ2pm2cnwXXAVgo6Jnb3SLQWnOoQhYcNqR61OZDS5N+BRT3nDWCEyADck/o7Gcs180IaS8QhI7NpWPrwUq8ddJrMgp+auQEpJYGmxIOBxVc5Nyt8EnxGglfzH4EHlTo3Dh4c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705696217; c=relaxed/simple; bh=pmWEJp5KOv9ixpF4HMVvrTZsIaVV/MNVaK2DmjucTJo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WVjU9elOLRnN2ZCKEwX/snn5s6FL/EShbS0tzRiabk/W3gYcgPg0GOxwbXAHl8GXH9v34SI48lhwjl+3tFaiVu9JWrmWfJf12bRdmb1PIBxApvs0dtIHAEry9w5c1rbPQ0NelgPiSl8JRPznwHscYw+HmRZD6+l6hU80ViH7Mws= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1705696214; bh=pmWEJp5KOv9ixpF4HMVvrTZsIaVV/MNVaK2DmjucTJo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SBBBevFOEAxX1K5OY5tOWFKL4zRJmEIJoLdAq9InRC3BcOgWRT1kfmILEy8Cnk2uI ikCDdnKs/XdFFONGmXaqX5T+K2/upT15UgThXlCsyH9lN01KyGRPMsnwxkyN5mWaZz BySqW+F6WFgXw/77q8jmrxBsUZosvtFO9nM1IhbU= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B409D1E092; Fri, 19 Jan 2024 15:30:13 -0500 (EST) Message-ID: Date: Fri, 19 Jan 2024 15:30:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: remove SYMBOL_*_OPS macros Content-Language: fr To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20240119163148.70597-1-simon.marchi@efficios.com> <87o7dhl0bn.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87o7dhl0bn.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_STOCKGEN,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/19/24 12:06, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Remove SYMBOL_BLOCK_OPS, SYMBOL_COMPUTED_OPS and SYMBOL_REGISTER_OPS, in > Simon> favor of methods on struct symbol. More changes could be done here to > Simon> improve the design and make things safer, but I just wanted to do a > Simon> straightforward change to remove the macros for now. > > Thanks. > > Simon> + if (auto computed_ops = var->computed_ops ()) > Simon> + return computed_ops->read_variable (var, frame); > > This one spot uses auto, but no other change does. > That seemed weird. Normally I wouldn't mention it but I also noticed: I initially used auto everywhere (kinda used to that now, because of other projects), but then reverted it because in GDB so far we prefer not to do that. I missed that spot. > > Simon> + if (framefunc != nullptr) > Simon> + { > > Looks like the wrong indentation here. Will fix and send a v2, thanks. Simon