From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40065.outbound.protection.outlook.com [40.107.4.65]) by sourceware.org (Postfix) with ESMTPS id F236C3858C60 for ; Mon, 28 Feb 2022 10:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F236C3858C60 Received: from AM6PR04CA0022.eurprd04.prod.outlook.com (2603:10a6:20b:92::35) by DB9PR08MB6618.eurprd08.prod.outlook.com (2603:10a6:10:263::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Mon, 28 Feb 2022 10:47:03 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:92:cafe::2b) by AM6PR04CA0022.outlook.office365.com (2603:10a6:20b:92::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25 via Frontend Transport; Mon, 28 Feb 2022 10:47:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Mon, 28 Feb 2022 10:47:01 +0000 Received: ("Tessian outbound 2877e54fe176:v113"); Mon, 28 Feb 2022 10:47:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 66a7d5a7a979eef7 X-CR-MTA-TID: 64aa7808 Received: from 25dc9aeead38.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 70424E66-118F-4EB5-BA7F-2CAB2D07A0D4.1; Mon, 28 Feb 2022 10:46:51 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 25dc9aeead38.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 28 Feb 2022 10:46:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fidiQoJH6IDuguFQs3oq/2ds7DwQNf9UA28Q/6P/U4cdDAoBQc2PUjqZeZpHnYC9/IoARDcMXOVYv/FPcqaLvQr7bZf8YtQBr4DungAmpZqKkENHNuiqTAh1jNK7VnyFq6e2hfda50saxo9GQXeEBsDHC6F4POJYKtOeMPCN6OxaA1YPO+vR+eHaWOGK+Z/+22ToA1kCSiBoiwIjhmKEoHIOd7i0ixxHD4TnY60NZhkM7VgqThB4GqDGFK5GZRcNKeusBK4N2Pi6y6S3NZ9gktmHaxrcvd9/vmb+ug1tUuEqMWVfD6hzGhGXZK/xLQZLp10ig+tQsiB923//wZnLSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n+4CHQLEeYjUQFXUbQLWqRES5y9NSPEhw4oEXJZV4JQ=; b=i1C/Eld7FDgiOq/OsLAJKuKPgl2SSoCi8rvPWcCTUa6cylu5Sbj3kgNzYkvSuNiNVjYY9YWDfYrSyNzJ9FBLGj2BjxdTAvwxdj/H31Y2mceDA/khO6wttb42Yheq9ytfL65fmXKIZjNtyooAFWwNO4ulgIPgYjhl9j+zZwW/aYht2K0xE006KvF8hmqwumR/RcDckMV12UReOjsxsCL14Ej2dqWqiVCcFSFFDkb3nomggolgA6isuoWlAQaJY6Gb/3/meVkLuAWTqLlPdSvzxmd1InfBFcArwPEg1mOF5yIRngjXtiJSezmcqdMprpJw8Cw3tF0qhfJ0bdCh30boeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) by DB7PR08MB3532.eurprd08.prod.outlook.com (2603:10a6:10:4f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Mon, 28 Feb 2022 10:46:47 +0000 Received: from VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::bcd8:8251:cd46:f063]) by VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::bcd8:8251:cd46:f063%5]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022 10:46:47 +0000 Message-ID: Date: Mon, 28 Feb 2022 11:38:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 0/5] arm: Add support for multiple stacks on Cortex-M Content-Language: en-US To: Joel Brobecker , Maxim Kuvyrkov via Gdb-patches Cc: torbjorn.svensson@st.com, Yvan Roux , Luis Machado References: <20220204084151.14480-1-christophe.lyon@gmail.com> <45235B67-731E-4EE7-81E1-62A720E963A4@linaro.org> From: Christophe Lyon In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0124.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::16) To VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5851032b-693c-45a3-90df-08d9faa7a727 X-MS-TrafficTypeDiagnostic: DB7PR08MB3532:EE_|AM5EUR03FT018:EE_|DB9PR08MB6618:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9pQKc91d09L0uptqA2OF5UNkX3YB5SkzsVJ9YbQPFFP6pgM/krOj/IRMRf0swSL3H7kamB37TDL0J8qIo7qktgc8Sbv4k8rrH9fcq5pebm+536OdC6T/VT5bo15CsWa4Dqs5iv5tp+cHr/X3u4BQBIGDRccaPpTmosS66npaNUpCKQ1f8+LF4R1AlEQEeLuukVwTkI23Je4fQ1iEQx6gx1+qPK8QnXiVmgrswFJAabSxmpJ6arfgkkAksGFVCoQe7OvS6rxCtKviT7BSHH6QeXifbceWUNoaTHoE1nfHlJAn4xy2wJo0/fRJBCp6JC3mNKP8CceKvcCGQmrenteoVZy4Ee8wO5riirYL0cySwrdQGNzSBWr1E+hHA8LceR9gySimwrtPVCUyqknFQVtkQkIFk1EKo9DUXEZ1NPkl7fL7H+yrFd/lJpBk5YfirUPFg2l5NCrIlWFrpnXPT/niLHw2HkdBDRzQ4LUYMWiBwzk/gMaGEJtpuyexUMIbZBdcLcg6w2AkdBe4YrBayawGiEbPFko6GC90lV/SC7rRAre1Ogzsss2n639VKKwGkY7FbtfB8JGW0H843A7RlI7d1YbzX+28cWIhaSjqgPslOVC0ORWkJHVQmyb67kUefFiQrliG5SVGD6OY1uJZNG9SxEcaerk+C54vaEI1D59wyVhLbI+aNWCWC/5O9Ni2JAHDRFUGPF47c5YsnXGHHGIF8P2LMJ7etG44qhXNNKbbcWsEGbd30YM5N+iVlgpLBPkOaY/nmmcPebXvm0wmyu8CzVvuUnil4xXeSXlbOyUV8NKTq6Ch+bhyVKbK3XasMiq4 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3694.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(54906003)(83380400001)(6486002)(966005)(316002)(110136005)(36756003)(186003)(44832011)(5660300002)(26005)(53546011)(8676002)(31696002)(66556008)(66476007)(6506007)(6512007)(6666004)(66946007)(2906002)(31686004)(38100700002)(508600001)(2616005)(86362001)(8936002)(4326008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3532 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3abf2b8c-c07f-41a8-e1c7-08d9faa79de1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 29fN/MHoru1URMv6C22Fx3X0VurtRYdypKEIqUfKr+biuPsLVmD6RVY6KdqxyDMnMScqKPRkEBNFRoJK3eNZHxMJTVD54s3VN87q0yX/na8egni7bHhaELYo+f5thpY8w4oQrv0U85zMsmCu8OFyp6/xbHXKjmCO14CsmAX0yMQ2aoivLjv8VZ1L5W5Wh2Pw/chF1zhY7S9Vp2J2YfkhDHPcwdfwyH2FHOhQjI89x4ohKD9YiGLX6HcYKsri20sDG8h7DTxRWUaGXfGGnIpqIauvc7/tRzBKrnFdnJWd8uW0YhRHrtHUO9KleDyGcSMQ5jl4yeYowbniLzKNVp4h0mNcEsWB2WMJdiMmByDq3xayWjPx5+Dpcmzm0Hsi4GMuUpv6l/jWhstdrjIwqSl1HxqXxevW9SZZAUvcLDqPtKci3ZFrNm6T7z0H04YybTYTiZ10k5u/vjGiG3RNZZhPp2EFCScW30X3+xX1xRzF3wiPERzYSqsCkHj6f1Mb5E/zkkmA+e9QWtg5cZ9+UtIlNFjji8BJqXT19TG3X6udFuWNT7RxmF6lr1wM07sl38muBHH8NPMdlTjBETJaD/6udyXS2yKQJJFEIZwwtutEuusXGV2Lf/dWVla8qbFKgJm5bF/UuH6+PW7eabO/qeYtn6wPZscXZo6pxBsY6EE2uQFbBRYpetxWpVSoRCEwxp78N3ibfWEfg1VlJ65M8SsinCsFXvlBEsgmcI6pNaoi9UkIxQSnbWmnMwi7Zgim+crupLZO+cyUUNEvzUlV53DwdGjFcGNjnhaT+ELUJWh0znaBEP+QavLCu2gYerxCXrE8j8tSNxsX8obFdlINBdhsZQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ErrorRetry; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(83380400001)(31696002)(86362001)(6512007)(6666004)(6506007)(53546011)(186003)(26005)(2616005)(336012)(36860700001)(47076005)(82310400004)(81166007)(356005)(8936002)(4326008)(8676002)(5660300002)(70586007)(70206006)(31686004)(2906002)(36756003)(44832011)(508600001)(54906003)(110136005)(966005)(6486002)(40460700003)(316002)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:47:01.9725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5851032b-693c-45a3-90df-08d9faa7a727 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6618 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 10:47:07 -0000 On 2/27/22 12:35, Joel Brobecker via Gdb-patches wrote: >> Will you be able to review this patch series from Christophe? > I see that the v3 series was posted on Feb 4th, while on Feb 6th > I reviewed v2 :-(. This is really unfortunate that we don't have > a better system for tracking whether a version of a series is > trully the latest version. No problem, there's not much difference between v2 and v3, so your comments still apply. I should have answered earlier. > > Can you take a look at the comments and question I asked in v2, > and publish a v4 which takes those into account? Please Cc: me > on the submission of the patches, this will help me remember > to prioritize those patches. Sure! Luis and I changed jobs at the same time, so there's a bit of lag :-) Thanks, Christophe > >> Thank you, >> >> -- >> Maxim Kuvyrkov >> https://www.linaro.org >> >>> On 4 Feb 2022, at 11:41, Christophe Lyon via Gdb-patches wrote: >>> >>> From: Christophe Lyon >>> >>> This patch series introduces support for the multiple stack pointers >>> on v8-M architecture (MSP_S, MSP_NS, PSP_S, PSP_NS). >>> >>> This enables to unwind through Secure vs Non-secure context switches. >>> >>> Along the way, the first patch adds support to detect vpush >>> instructions in function prologues, which in particular is used in the >>> CMSE trampolines. >>> >>> v3 fixes two small silly mistakes in patches 4 and 5. >>> >>> Christophe Lyon (5): >>> gdb/arm: Fix prologue analysis to support vpush >>> gdb/arm: Define MSP and PSP registers for M-Profile >>> gdb/arm: Introduce arm_cache_init >>> gdb/arm: Add support for multiple stack pointers on Cortex-M >>> gdb/arm: Extend arm_m_addr_is_magic to support FNC_RETURN, add >>> unwind-ns-to-s command >>> >>> gdb/NEWS | 5 + >>> gdb/arch/arm.c | 6 + >>> gdb/arch/arm.h | 1 + >>> gdb/arm-tdep.c | 698 +++++++++++++++++++++++++----- >>> gdb/arm-tdep.h | 10 + >>> gdb/doc/gdb.texinfo | 10 + >>> gdb/features/Makefile | 1 + >>> gdb/features/arm/arm-m-system.c | 15 + >>> gdb/features/arm/arm-m-system.xml | 12 + >>> gdb/features/arm/arm-secext.c | 17 + >>> gdb/features/arm/arm-secext.xml | 15 + >>> 11 files changed, 691 insertions(+), 99 deletions(-) >>> create mode 100644 gdb/features/arm/arm-m-system.c >>> create mode 100644 gdb/features/arm/arm-m-system.xml >>> create mode 100644 gdb/features/arm/arm-secext.c >>> create mode 100644 gdb/features/arm/arm-secext.xml >>> >>> -- >>> 2.25.1 >>>