From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) by sourceware.org (Postfix) with ESMTPS id 0EAD63858C2C for ; Fri, 22 Apr 2022 08:38:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0EAD63858C2C Received: from AM6PR10CA0031.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::44) by AM5PR0801MB1970.eurprd08.prod.outlook.com (2603:10a6:203:4a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr 2022 08:38:30 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::a6) by AM6PR10CA0031.outlook.office365.com (2603:10a6:209:89::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Fri, 22 Apr 2022 08:38:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Fri, 22 Apr 2022 08:38:30 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Fri, 22 Apr 2022 08:38:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9a09466d179dd318 X-CR-MTA-TID: 64aa7808 Received: from 1b556b76cbca.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5C6692D5-8390-4252-A717-6E879FC88347.1; Fri, 22 Apr 2022 08:38:23 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1b556b76cbca.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Apr 2022 08:38:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UnhNq1jCJgyl1qXc5hPy++riYrlculaAYfY5SU/iNC1RBeX/5P01sPYsXShcHMMvp8NY5GuBy4I69EPNW/pqy7c+bxVQJ4fi/y+hWpCDjhQ4E29XNOqm6rivNzvVPMGvBcePEVngd2dPkCmHFmnmWkd0HjfjPZhkY6nkgitf7YF+DWQQjRRe2jX/QjRt4LLNMyJduJvEB9JyBVBXMLMwmCpXGs/P3+JTAt2DBbCPw1E2YW2/nErzGwVoiMbF/O/lj99IvMzGxhNOs7edhutHzAtNaAyVmF5jVBzuZuDD8s/r+vF3kNfXzPnqpGj3PFcHu0buO0vqde+csqZlulubgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Te96AB++DfNV8di65Tt4P8tgkhiJUTbO+5uWA6dt1c4=; b=SmAGivBJR8uA2GgIdHRYQTCXYnZg+0PuVf8wIK1LHLb6CVs/D230BLw8Qi5vEk7plDw+gDSllOfRMMO2Pj4BZObJPFlwiUwvGcnykxKZ9cCALNHa5nyymcTbXAmv3D4WY656bkIXM9paIzaNB/seJERIzh7rUI4l4cgSeTAAPF5noldGBwH1ZtVcauLtmmTeqwHOkJzjNuUbgIqZTOKG9tiPWp4aHxbIoEggBalHCCmsRIHvhfthhoaFLFhz4E02y/cICqVB2zJID5472N+2N55xnbUgKMMz+KR+pg1gLh2YbrnriWeGChk+IMi/ren2+2ZnnXXU9vboYYK5Im/Euw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by HE1PR08MB2938.eurprd08.prod.outlook.com (2603:10a6:7:37::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Fri, 22 Apr 2022 08:37:49 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 08:37:49 +0000 Message-ID: Date: Fri, 22 Apr 2022 09:37:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH, v2] [AArch64] MTE corefile support Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20220331140343.9047-1-luis.machado@arm.com> <20220421152040.128278-1-luis.machado@arm.com> <83pmlaqvrl.fsf@gnu.org> <83v8v1plkl.fsf@gnu.org> From: Luis Machado In-Reply-To: <83v8v1plkl.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0077.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::17) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: aed1eb7a-fa15-45dc-df53-08da243b7a87 X-MS-TrafficTypeDiagnostic: HE1PR08MB2938:EE_|VE1EUR03FT023:EE_|AM5PR0801MB1970:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tZLPiBZ+DxYnbIBX2WLaTBcfJ9IBx0QQTmqgw1+ezv+SXg/hUV/lmNZof03rPj/idwkGpwQzjWTvM6DuL3ltIwE3a4ocKqwJhXF5QdmLiQKSsuKu0WsAPY9MP23fSMOEQHKRaT4uyr7CseanWWROciZ+/TBUyNOffq5OcowCnACy3dHwqYZS2C6yt8jMENgfsMsWwdNdeiYU4rQE41hLl5j2sc7LfGWdiscHOJEZGHl0AXbZSzfoMZ3XqNJ5G2K6AeGpIZ3X+5LP1+eFWJ9SSRvxtEzeM5zB3grOJM7soAbvNqEhgKR9q2LyKRPDEdlwEXiO7MaELoxooL1T5nJb6v+BASVE7pQlU59MZStoY9iyuEva3849qrYkeJQ8KeYdTy9FiQWLT21Frs4Xvcu51oeFYFh9oTm8wHSPEKilPoDIErjNHWS5+2lBZnDuU0MgGn1Ynwua5ONePQ4N1cvXOwqyh76NMDIkLOVqTyCyrjhb7+4IhJXliX8OrAChZDN91E4UGrkCOnE+Hok5CyzTn+SS/sRfJL70aWsar9o+f2x9RsqaWhs93RWyBcVc9x/kHGfJymKdqtySNa0DrwOIr8u+dYAP5w6T2NYqHk5TlNu0Jj1IZonqHjEXIkltgFRcSF+t/0OwkgnorvtbjmnhMH7oFZ6mOOX/2ZhVdwYZ8GL6lhcrxEgjn1KVK15X4+wVUKxaGCtaWcjUklNEVxYfr/IdTluf4fm1PoQtgNZTjpw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(4326008)(8676002)(66946007)(186003)(6506007)(53546011)(66556008)(31686004)(316002)(2906002)(8936002)(6486002)(31696002)(6512007)(86362001)(44832011)(508600001)(26005)(66476007)(83380400001)(6916009)(38100700002)(36756003)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2938 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c452e206-c111-4eee-87b7-08da243b6204 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a+nKXXvYwyU9rHxDwWyJZVSymFy+OUBMjYRLYLtJgG/S4gHvCuXGxLjq7GttSjvlq73fzoNfJzUOXg175bCvgzZnVB2PEt64Ol/Ttc/SVskb6SvvhSv51C/Q0WN6fkBuvd72ffH7PjEdEc7AnVHvzNsFyRmqqsfL6znkf+ANBTgFRhKZQsE8LNPoETALQUgJSZInwHiqWzYkydlm9LD+WGBlWhpoYtdO9lVxbY26j/KlrkFGJ/fbDCA4xAtbnL09jiswsRe694i6IR6aOXqFbrrX8WeTV/nashIocObOObeYhNyEWARQAGu51Z1b5ZJg+9fTTQHniAqnB9Yt26Kv/bf54iYR7rzdt2LCXcjEFNZc91sAw7U5MOfhZnv3sgV3J0PZtG+bpDxscb+6IM8VioiCkdPruQwelqRikwkDKDVn9GFtzwP4bCvMnBH7uA2WeROEpiOAE/nzP0ClUH6mCu7yRKHdqjY1Zl2XICYWmN9BAYU56Qb4eA26pXlm80wf9KgAteWY4ZaENirf22WDSJiJYMa1GgihjBlCcvmgrEWMLoSzBbDpuCt6dVW+0k61I8G1eAKBkldyMXM8cBEGJeqT6bKTQ3XGbBVx6EPm2l2WgrRW1OKs43gjwU7pJ/5Wkev9rjifcwVvXrOgSESB3vmsy3IH+qm/vSXqJJzg6cNYj4x7WofKgriZxIOF6IMzGMEX6D16t+02ly1XzA/goQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6862004)(70206006)(70586007)(356005)(36756003)(40460700003)(6512007)(316002)(36860700001)(86362001)(6486002)(83380400001)(508600001)(31696002)(8676002)(186003)(4326008)(31686004)(81166007)(26005)(82310400005)(6506007)(2906002)(336012)(53546011)(8936002)(5660300002)(44832011)(47076005)(2616005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 08:38:30.2804 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aed1eb7a-fa15-45dc-df53-08da243b7a87 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1970 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 08:38:37 -0000 On 4/22/22 09:30, Eli Zaretskii wrote: >> Date: Fri, 22 Apr 2022 09:12:44 +0100 >> Cc: gdb-patches@sourceware.org >> From: Luis Machado >> >>>> *** Changes since GDB 12 >>>> >>>> +* GDB now supports dumping memory tag data for AArch64 MTE. It also supports >>>> + reading memory tag data for AArch64 MTE from core files generated by >>>> + the gcore command or the Linux kernel. >>>> + >>> >>> I think this should say something about the significance of this >>> feature. Otherwise it is completely unclear why would GDB want to >>> support that. >>> >>> Same comment for the addition to the manual. >>> >>> Thanks. >> >> It is a bit short. How about the following additional paragraph? >> >> "When a process uses memory-mapped pages protected by memory tags (for >> example, AArch64 MTE), this additional information will be recorded in >> the core file in the event of a crash or if GDB generates a core file >> from the current process state. >> >> The memory tag data will be used so developers can display the memory >> tags from a particular memory region, and will also be used to show a >> detailed message about a crash that happened due to a memory tag violation." > > This is fine, but can what's described in the last paragraph be done > by GDB commands, or does it require external tools? In the former > case, we should mention those GDB commands; in the latter case I'd > settle for mentioning the fact that external tools are required. No external tools are required. GDB already supports displaying memory tags automatically if it detects the process is using those. We can explicitly mention the 'm' modifier for the x command and the memory-tag sub-commands. Would this be more appropriate for the manual entry? Or do you think it makes sense to mention it in the NEWS as well? > > Thanks.