From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id CF2483858D35 for ; Wed, 26 Jul 2023 21:43:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF2483858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RB6pL4hCGz3vBX; Wed, 26 Jul 2023 21:43:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RB6pL3xQkz4LS6; Wed, 26 Jul 2023 21:43:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690407802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OH5w25gTru3rSe22y06Wf5+XRWrY1JBZk7xtrs/nT9Q=; b=aaPtxQk5/VbKFJV1nVTpMcJCw5GqVwVNY1axMwGUxMG9CMhvjBVMngAYigMld7GDKaI+Ek wjJxvP20YfGa6qOr2gmv8co5UEX1ZFViStQdUzgBryOLiDXz+DgXkQagyvf+ZuGTvPs/dr mA0IcuOAGqzlkj3uZN9IuD82jxwvA8bOdEdBhB3FWzumKtrkvdGWHCPw2+nyoTg+y0e8kf TN4NA+a5HUzPcDiaAWk0zrMdpzl7z0xHEOA9xgGXII/HRl/BWhTLnLOFsSSSRqVBA/f0pA 1+bUw8dmnxXWrdYK/UGpr8RCsqvsjHXeFVPNylyOr8XdXzYJ72sw9ZaJCMpNkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690407802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OH5w25gTru3rSe22y06Wf5+XRWrY1JBZk7xtrs/nT9Q=; b=QNdPRNqQtfftbBNkzdWhl9C26Hl0snxB7XoUMLe+9aNrypfDp1g3PeWJYf0qhkD0Xo8zCB y9E8uczm3XBknSLSI8wmfHXxfY7AQ6UNGMn5Qmn6U1gErSmD4mSlKykcecYlW35h4GYW+R llHV0A8ouLaAVlymY8rLb1Iu7znDRD/wZnaszeb1cp9Ntr3Xpw3MuPoCLhUfc3AWIMr2mv S1BJVx88ydp/sulI8gEk8EHkfJ9LHFKcKxlEFRbR+fAh0jNx4h7pH1nEBRR3MbAFONJUwt 5egsbnjwSDh3nz65fJ4sA1LqsgH2ky3hDCwBIHG1f5nzQ+WxWwzOGCEYazjCNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690407802; a=rsa-sha256; cv=none; b=L6XMnkkFE4Bb3BhwTpdA3zLlN6JN5zBA0GQ10xXdtqgvBkOWG5qIcmOM6b++UDmG+0q4au KozJDI4TdBCTV7UBzl9GZbL+GY1ikuMBr1Xr7+42Kgg0WlaP0q5Byxgv0erALet7zUVtML YQphji6luShxkZ3HKIbxkapXaW3DVuhxwmHrfU7+JICVU+nK3bccXDd2dBd/pfDM69y9j8 StjF86a4Pl2mBBlYEpAiqKZecm62D+YSNmI5Mqd99qxVgS882M+0ZLmTnqJLXQedO4W3j/ xblSLCoa+pBKyV7ZNTycrdGStCAnc4nk0/oVmHj4RyecUSosZFG2VWdsye3qQA== Received: from [IPV6:2601:648:8680:16b0:3912:750d:bdfa:28ab] (unknown [IPv6:2601:648:8680:16b0:3912:750d:bdfa:28ab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RB6pL10GZzJdy; Wed, 26 Jul 2023 21:43:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 26 Jul 2023 14:43:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 06/15] gdb: Update x86 FreeBSD architectures to support XSAVE layouts. Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-7-jhb@FreeBSD.org> <9d887f0b-b973-569f-8f9c-305e7d9ed7f9@polymtl.ca> From: John Baldwin In-Reply-To: <9d887f0b-b973-569f-8f9c-305e7d9ed7f9@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/26/23 1:04 PM, Simon Marchi wrote: >> @@ -241,43 +241,49 @@ static const struct tramp_frame i386_fbsd64_sigframe = >> i386_fbsd_sigframe_init >> }; >> >> -/* Get XSAVE extended state xcr0 from core dump. */ >> +/* See i386-fbsd-tdep.h. */ >> >> uint64_t >> -i386fbsd_core_read_xcr0 (bfd *abfd) >> +i386_fbsd_core_read_xsave_info (bfd *abfd, x86_xsave_layout &layout) >> { >> asection *xstate = bfd_get_section_by_name (abfd, ".reg-xstate"); >> - uint64_t xcr0; >> + if (xstate == nullptr) >> + return X86_XSTATE_SSE_MASK; >> >> - if (xstate) >> + /* Check extended state size. */ >> + size_t size = bfd_section_size (xstate); >> + if (size < X86_XSTATE_AVX_SIZE) >> + return X86_XSTATE_SSE_MASK; >> + >> + char contents[8]; >> + if (! bfd_get_section_contents (abfd, xstate, contents, >> + I386_FBSD_XSAVE_XCR0_OFFSET, 8)) >> { >> - size_t size = bfd_section_size (xstate); >> - >> - /* Check extended state size. */ >> - if (size < X86_XSTATE_AVX_SIZE) >> - xcr0 = X86_XSTATE_SSE_MASK; >> - else >> - { >> - char contents[8]; >> - >> - if (! bfd_get_section_contents (abfd, xstate, contents, >> - I386_FBSD_XSAVE_XCR0_OFFSET, >> - 8)) >> - { >> - warning (_("Couldn't read `xcr0' bytes from " >> - "`.reg-xstate' section in core file.")); >> - return X86_XSTATE_SSE_MASK; >> - } >> - >> - xcr0 = bfd_get_64 (abfd, contents); >> - } >> + warning (_("Couldn't read `xcr0' bytes from " >> + "`.reg-xstate' section in core file.")); >> + return X86_XSTATE_SSE_MASK; >> } >> - else >> - xcr0 = X86_XSTATE_SSE_MASK; >> + >> + uint64_t xcr0 = bfd_get_64 (abfd, contents); >> + >> + if (!i387_set_xsave_layout (xcr0, size, layout)) >> + return X86_XSTATE_SSE_MASK; >> >> return xcr0; >> } >> >> +/* Implement the core_read_x86_xsave_layout gdbarch method. */ > Should be: > > /* See i386-fbsd-tdep.h. */ Fixed. >> + >> +bool >> +i386_fbsd_core_read_x86_xsave_layout (struct gdbarch *gdbarch, >> + x86_xsave_layout &layout) >> +{ >> + if (i386_fbsd_core_read_xsave_info (core_bfd, layout) == X86_XSTATE_SSE_MASK) >> + return false; >> + >> + return true; >> +} > > Rewrite as > > return i386_fbsd_core_read_xsave_info (core_bfd, layout) != X86_XSTATE_SSE_MASK; > > ? Yes, and I'll fix it in i386-linux-tdep.c as well. > Otherwise: > > Approved-By: Simon Marchi > > Simon > -- John Baldwin