From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id DCEC83858C41 for ; Fri, 10 Nov 2023 08:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DCEC83858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DCEC83858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.220.28 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699604021; cv=none; b=AqqB67xSCcAE5Z1Tw24hFV6aS5kWx/xnYbJlhNaTlZdwk0DSHP0yl2JT0Kp3sNMvs9xFMrnX4bmZjM9gnVAf2osYoVrGnnkegiu425bA4wWZsuYoute0fRcng+i1egib4QTaT7kt4eRKm+XFhTaF/6L7wl8LIdEx2635EopHb6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699604021; c=relaxed/simple; bh=CEbzagbogDMwK3qKXwZYMHg/Bc4a8rtvvHK6ic5OYwU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=pQjZMtN3yrWClR4J+pvh0kHKxxDf9po0NvyRpCZLQcv6hMdQh+rOAM4vWn8ETnjBEmrGA5tzLpdyZYwe/GbsVTAGUpw/oXGFV4CcYo5nq71umLGdrpw/01Cd4PCulL3v2DhV0mDalgeMrkIiDcRGdIeKEzLIdcJsjEFJK7YPxXE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1FA7521999; Fri, 10 Nov 2023 08:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699604019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/egHJcWUdfoBn8HLnUNW3eu6/L1mCBPeKJPy1B7MVmo=; b=lyPOeQJPhI1hmUcx59YwTw3sAKz8EcmGd9sm+upRhv3IH7THggz61BZJ5klJxgAALlqTj8 4DtU7OomgkJeeyAQ81yGrMhFwSaGKPuSeGXK9fwdLfVbgqUQNaUNZpuETzISjO/oh1feKI FUhbWs3uYmLYuhsXB2DDtPZrycmbmmo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699604019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/egHJcWUdfoBn8HLnUNW3eu6/L1mCBPeKJPy1B7MVmo=; b=EcyMOexUem4nSrJ/nr/qhs6IYBNI9oWVFGBY/mE/qZoHsEL6Glo9Mb0wLSAsLPuvJ4GV1Y kk4QZ3MU4MnoFmBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0B8DE138FC; Fri, 10 Nov 2023 08:13:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MKdgOzLmTWVHJAAAMHmgww (envelope-from ); Fri, 10 Nov 2023 08:13:38 +0000 Message-ID: Date: Fri, 10 Nov 2023 09:15:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] [gdb] Eliminate local var pspace in inferior.c Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231109150021.5504-1-tdevries@suse.de> <20231109150021.5504-3-tdevries@suse.de> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/9/23 17:31, Simon Marchi wrote: > On 11/9/23 10:00, Tom de Vries wrote: >> Eliminate local var pspace from functions add_inferior_with_spaces and >> clone_inferior_command. >> >> This interchanges the order of the new program space / new inferior events. >> >> Update test-case gdb.python/py-progspace-events.exp to reflect that. >> >> Tested on top of trunk on x86_64-linux and ppc64le-linux. >> Tested on top of gdb-14-branch on ppc64-linux. >> >> Suggested-By: Simon Marchi > > Sorry, when I suggested this cleanup, I wasn't aware it would have > user-visible changes. Since there isn't a need for this except "make > the code a little nicer", I retract my suggestion. Ack, dropped in v4. Thanks, - Tom