From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id ED8353856179 for ; Fri, 21 Oct 2022 08:43:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED8353856179 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-58-xLdtQ21tNK-2lqBLPqyFGw-1; Fri, 21 Oct 2022 04:43:57 -0400 X-MC-Unique: xLdtQ21tNK-2lqBLPqyFGw-1 Received: by mail-wr1-f71.google.com with SMTP id h26-20020adfaa9a000000b002364ad63bbcso587329wrc.10 for ; Fri, 21 Oct 2022 01:43:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9kM21eg1bGLltGrw24+FTeMuW4f18IimnYl1kFvaKBY=; b=mu16fdUg5D/09zuhYC6eulRg0xxgtE0TNC9cub3/1FR6nJCqeHar44QbI1dIC/5m8+ F4kOzS0W0n0VffVsc0q2BTCoGimuPMCWuCbgxQYsjvzgqOEsQf611+1h+jIy1md91kI+ X+36gbtTlSVXCfiF0uHgRS61Nz8MFt6hKwBFYkDIJNZ8+U6htTKPdKCN7DGqGd9sN951 HbNOLk5q0FXtdcCXFNPs5Pz+u/TAw29MHkj/1rPcPk1cQ70u+XLiB/KzLpnC1FR02AvG FQaIEdS6lO0oSlLTpKOOciA+cUkz5+ZFDw1LDMFTUfoo6nsggnd2qTZi97DBALxcMeDj 1Tug== X-Gm-Message-State: ACrzQf1pi2nPAZt2y3oeR5KJGjxjS1g1Yw/cq2TDNIA95ACU0zia67g9 Xx0SzXXNLCXYOQsOB6cjmRByQDy//1DhIuO8/dqOJvxyP41Nsd0bS0RYqQzmB+CNbyWkIP/I7U2 fznWbhUJHCTkpxPogeuKNEOmIkHPnEe7zR913TVVjVbYMXmcy1jKHpbEF+PqT1S1eBObS9ZUQ5Q == X-Received: by 2002:adf:f58b:0:b0:22e:3c4:cf83 with SMTP id f11-20020adff58b000000b0022e03c4cf83mr11890803wro.379.1666341836130; Fri, 21 Oct 2022 01:43:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Omd/GyC+8LvCRIQjPYHRthejIDrAT85ktO1KEuZ0pZ5J0ZjTsDXEnguBmG/H1GmCErBuSjg== X-Received: by 2002:adf:f58b:0:b0:22e:3c4:cf83 with SMTP id f11-20020adff58b000000b0022e03c4cf83mr11890791wro.379.1666341835854; Fri, 21 Oct 2022 01:43:55 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id v21-20020a05600c15d500b003b4e009deb2sm2001634wmf.41.2022.10.21.01.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 01:43:55 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCH 04/12] gdbserver: add comments to read_inferior_memory function Date: Fri, 21 Oct 2022 09:43:40 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 08:44:12 -0000 Just adding some comments to the gdbserver read_inferior_memory function. No actual code changes. --- gdbserver/target.cc | 2 ++ gdbserver/target.h | 3 +++ gdbserver/tracepoint.cc | 2 ++ 3 files changed, 7 insertions(+) diff --git a/gdbserver/target.cc b/gdbserver/target.cc index adcfe6e7bcc..6b29c99a61b 100644 --- a/gdbserver/target.cc +++ b/gdbserver/target.cc @@ -79,6 +79,8 @@ set_desired_process () return proc != nullptr; } +/* See target.h. */ + int read_inferior_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len) { diff --git a/gdbserver/target.h b/gdbserver/target.h index 6c536a30778..a49d7d4bac0 100644 --- a/gdbserver/target.h +++ b/gdbserver/target.h @@ -697,6 +697,9 @@ target_thread_pending_child (thread_info *thread) return the_target->thread_pending_child (thread); } +/* Read LEN bytes from MEMADDR in the buffer MYADDR. Return 0 if the read + is successful, otherwise, return a non-zero error code. */ + int read_inferior_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len); /* Set GDBserver's current thread to the thread the client requested diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc index 18b2b0b3d77..efcdfe12beb 100644 --- a/gdbserver/tracepoint.cc +++ b/gdbserver/tracepoint.cc @@ -344,6 +344,8 @@ tracepoint_look_up_symbols (void) GDBserver side. */ #ifdef IN_PROCESS_AGENT +/* See target.h. */ + int read_inferior_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len) { -- 2.25.4