From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 6C07F3858D37 for ; Mon, 10 Oct 2022 10:46:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C07F3858D37 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D3A2B21976; Mon, 10 Oct 2022 10:46:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A87B113ACA; Mon, 10 Oct 2022 10:46:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ca2yJwb4Q2PFMgAAMHmgww (envelope-from ); Mon, 10 Oct 2022 10:46:30 +0000 Message-ID: Date: Mon, 10 Oct 2022 12:46:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PINGv4][PATCH v4 0/5] Smart pointer wrapper for frame_info Content-Language: en-US To: Bruno Larsen , Tom Tromey , Bruno Larsen via Gdb-patches References: <20220830100837.926692-1-blarsen@redhat.com> <2c1d8266-e990-3f20-4982-81baca607d23@redhat.com> <7342727b-3947-c97a-f380-28b0252f3389@redhat.com> <2048ae6a-07e8-8743-2030-82c7f0fee4d2@redhat.com> <87sfjzs9zd.fsf@tromey.com> <472ae014-5764-51f5-caf7-352fa543a530@redhat.com> From: Tom de Vries In-Reply-To: <472ae014-5764-51f5-caf7-352fa543a530@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2022 10:46:33 -0000 On 10/10/22 09:55, Bruno Larsen via Gdb-patches wrote: > On 07/10/2022 21:35, Tom Tromey wrote: >>>>>>> "Bruno" == Bruno Larsen via Gdb-patches >>>>>>> writes: >> Bruno> ping! >> >> I had a couple minor nits on patch #5, but you can just fix those and >> push it all without re-sending.  Thank you for doing this. > Thanks! I'll rebase it and push the series in a second > I'm seeing a build breaker on x86_64-linux: ... /home/vries/gdb_versions/devel/src/gdb/guile/scm-frame.c: In function ‘int frscm_eq_frame_smob(const void*, const void*)’: /home/vries/gdb_versions/devel/src/gdb/guile/scm-frame.c:137:11: error: ‘frame_id_eq’ was not declared in this scope return (frame_id_eq (a->frame_id, b->frame_id) ^~~~~~~~~~~ ... Thanks, - Tom