From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72295 invoked by alias); 6 May 2019 20:56:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70813 invoked by uid 89); 6 May 2019 20:56:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=sk:_initia X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 May 2019 20:56:38 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 6FAE1441E; Mon, 6 May 2019 20:56:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A21C389C89; Mon, 6 May 2019 20:56:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 2CB50173DE; Mon, 6 May 2019 20:56:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH v2 19/31] Convert fbsd-tdep.c to type-safe registry API To: Tom Tromey , gdb-patches@sourceware.org References: <20190503231231.8954-1-tom@tromey.com> <20190503231231.8954-20-tom@tromey.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: Date: Mon, 06 May 2019 20:56:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190503231231.8954-20-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A21C389C89 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00177.txt.bz2 On 5/3/19 4:12 PM, Tom Tromey wrote: > This changes fbsd-tdep.c to use the type-safe registry API. > > 2019-05-01 Tom Tromey > > * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers. > (fbsd_pspace_data_handle): Move lower. Change type. > (get_fbsd_pspace_data): Update. > (fbsd_pspace_data_cleanup): Remove. > (_initialize_fbsd_tdep): Update. Thanks, this file looks good to me at least. I'm also still in favor of the general idea. -- John Baldwin