From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70384 invoked by alias); 26 Mar 2018 14:44:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70367 invoked by uid 89); 26 Mar 2018 14:44:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Mar 2018 14:44:06 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF78940711D4; Mon, 26 Mar 2018 14:44:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57CB77C2D; Mon, 26 Mar 2018 14:44:04 +0000 (UTC) Subject: Re: [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash To: Andreas Arnez , Simon Marchi References: <1521043903-18837-1-git-send-email-arnez@linux.vnet.ibm.com> <1521043903-18837-3-git-send-email-arnez@linux.vnet.ibm.com> <5431d374-f1a4-65e0-82ee-a1758aa037a1@ericsson.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 26 Mar 2018 14:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00530.txt.bz2 On 03/16/2018 07:47 PM, Andreas Arnez wrote: > Subject: [PATCH] Testsuite: Fix ambiguous "break" due to libinproctrace > > Some of GDB's trace test cases define a function end() and place a > breakpoint there with "break end". However, when libinproctrace is linked > to the binary, there are multiple methods named "end", such as > std::string::end() from the C++ library or format_pieces::end() from > common/format.h. GDB then creates multiple breakpoints instead of just a > single one, and some FAILs result, such as these: > > FAIL: gdb.trace/trace-mt.exp: ftrace on: break end > FAIL: gdb.trace/trace-mt.exp: ftrace off: break end > > Fix this by adding the "-qualified" option to the break commands. For > consistency, change all occurrences of "break end" (and similar) in all > trace test cases, even if the current behavior does not cause problems. > Also, consequently use the gdb_breakpoint convenience proc. I agree this is the right patch for now. I actually posted something like this a while ago, but forgot to push it in: https://sourceware.org/ml/gdb-patches/2017-12/msg00123.html Note that I think it's a design flaw that users can run into this, though. I had filed: https://sourceware.org/bugzilla/show_bug.cgi?id=22560 Thanks, Pedro Alves