From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 697A23858D1E for ; Mon, 6 Feb 2023 19:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 697A23858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 316JDgTC032030 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 6 Feb 2023 14:13:46 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 316JDgTC032030 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1675710827; bh=4EJmafkVbfpHroNbU5XB2Wp/RcvlqsSqGw4FkA1dp9Y=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Mpeoipo+9XkfCR1Ad6o37EBHt+bgSVO5uoDTqFiCi4vR+xmTg8nGP5xBArYAaZk7/ pjXV87WzhIsdzLx0VYYeydHabhHGLdSfIw6nh6MlY6q0uwGwW3Vgo8Z6sr2qkFsXR1 4zT2CHfRIwfBeoMBNV9HV2u1jmvxkFc0mapBgNnc= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2B7F61E0D3; Mon, 6 Feb 2023 14:13:42 -0500 (EST) Message-ID: Date: Mon, 6 Feb 2023 14:13:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 5/5] gdb: make target_desc_info_from_user_p a method of target_desc_info Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20230203142126.286866-1-simon.marchi@polymtl.ca> <20230203142126.286866-6-simon.marchi@polymtl.ca> <3f54af90-f454-1d76-3370-80bd3c39e331@palves.net> From: Simon Marchi In-Reply-To: <3f54af90-f454-1d76-3370-80bd3c39e331@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 6 Feb 2023 19:13:42 +0000 X-Spam-Status: No, score=-3038.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/6/23 13:41, Pedro Alves wrote: > On 2023-02-03 2:21 p.m., Simon Marchi via Gdb-patches wrote: >> --- a/gdb/inferior.h >> +++ b/gdb/inferior.h >> @@ -345,6 +345,11 @@ extern void switch_to_inferior_no_thread (inferior *inf); >> >> struct target_desc_info >> { >> + /* Returns true if INFO indicates the target description had been supplied by >> + the user. */ > > There is no INFO anymore. Ah, thanks. I pushed this fix. >From f9b677528fdde6b1d5f402b75db2efcbe62c93d8 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 6 Feb 2023 14:12:27 -0500 Subject: [PATCH] gdb: adjust comment on target_desc_info::from_user_p Remove the stale reference to INFO, which is now "this target description info" now. Change-Id: I35dbdb089048ed7cfffe730d3134ee391b176abf --- gdb/inferior.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/inferior.h b/gdb/inferior.h index bac483f0f78d..72034cc4ffbc 100644 --- a/gdb/inferior.h +++ b/gdb/inferior.h @@ -345,7 +345,7 @@ extern void switch_to_inferior_no_thread (inferior *inf); struct target_desc_info { - /* Returns true if INFO indicates the target description had been supplied by + /* Returns true if this target description information has been supplied by the user. */ bool from_user_p () { return !this->filename.empty (); } base-commit: 85df9457b72e4a198b4edfc908017612fca59509 -- 2.39.1