From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by sourceware.org (Postfix) with ESMTPS id 010EE3858438 for ; Mon, 18 Jul 2022 19:16:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 010EE3858438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mail.api.win Authentication-Results: sourceware.org; spf=none smtp.mailfrom=api.win Received: by mail-lj1-f172.google.com with SMTP id r14so72002ljp.2 for ; Mon, 18 Jul 2022 12:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x7StPCq3/t2Ve+Ob6NkIue8kBZa++OlBO/+O53jKhUY=; b=3N8XMkKKlSlH1n9IexFOlh1q0e9K9/NBjCaBHyNDTt1uQ8ECckIPzPOGQAAILrDm7v r7T+VWWxjTW8XGHIBAEzIMqXIZVJCoVhVARBLCenBc0RTqml8DBIDJi7RMBFhgwW//mV Y99X2BpZOofEfw7LhrK8fAvnmJ+9Q1wUecrYLp+7ZqDW6Nv0ZhoQ4hhVoCw0YnERIgLQ WbEAxINsSuZimFGNmhmsze3FxALqSdnQbYxWLabOa9LiB8KqMjcSz8r897+UAjjntO2L G7UIzrEWGELEwlqoEXME0iRMRHarhPC0Bpok+nEFd8Ec0PckR7PCM9XFs6Bv73bK71Q2 4yVw== X-Gm-Message-State: AJIora9YMzDIkkqrOW3Gu/afUhZMkYgOr/3vy0qaflYOGsyE0jzgEpxK FMxIeJv+sl/u+QRK8nQPHcGs8mkHUgXAw1L+I7o= X-Google-Smtp-Source: AGRyM1vCuEuJYc2MOfMzWHeRF0ogk96Ql//hu7bS1cSAqzyvCGAIvu7WaX31k3r8hLpSH+T4K7UFnA== X-Received: by 2002:a2e:8889:0:b0:25d:53da:7963 with SMTP id k9-20020a2e8889000000b0025d53da7963mr12938320lji.335.1658171763566; Mon, 18 Jul 2022 12:16:03 -0700 (PDT) Received: from ?IPV6:2a03:1ac0:b0d6:4d64:ed46:3bcb:a2fc:89d9? ([2a03:1ac0:b0d6:4d64:ed46:3bcb:a2fc:89d9]) by smtp.gmail.com with ESMTPSA id n5-20020a05651203e500b0048a326d89e1sm1621976lfq.269.2022.07.18.12.16.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 12:16:03 -0700 (PDT) Message-ID: Date: Mon, 18 Jul 2022 22:16:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 (fix formatting and revert cli_colors to original state)] Add style tui-current-line command to colorize TUI current line. Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <87r12iqyr7.fsf@redhat.com> <20220718191118.57311-1-gdb@mail.api.win> <83o7xmnsh4.fsf@gnu.org> From: Andrei Pikas In-Reply-To: <83o7xmnsh4.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 19:16:06 -0000 > The documentation parts are unchanged since I approved them, right? Yes, it's right. On 18/07/2022 22:14, Eli Zaretskii wrote: >> From: Andrei Pikas >> Date: Mon, 18 Jul 2022 22:11:18 +0300 >> Cc: Andrei Pikas , aburgess@redhat.com >> >> Adds the ability to customize the colors of the current line of code in TUI. >> This may be desirable when code highlighting is enabled. Because higlighted >> keywords in dark blue color are indistinguishable from a black background >> (which is the default inverse color for a white terminal). >> Here is a screenshot of old and new behavior >> https://drive.google.com/file/d/1RnrDjvdsnV8y_lrnavs6wvQ6lXbtjRup/view >> --- >> gdb/NEWS | 4 ++++ >> gdb/cli/cli-style.c | 14 ++++++++++++++ >> gdb/cli/cli-style.h | 3 +++ >> gdb/doc/gdb.texinfo | 3 +++ >> gdb/tui/tui-io.c | 44 ++++++++++++++++++++++++++++++++++++++++---- >> gdb/tui/tui-win.c | 1 + >> 6 files changed, 65 insertions(+), 4 deletions(-) > The documentation parts are unchanged since I approved them, right? > > Thanks.