From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 6/7] Handle the static link in FrameDecorator
Date: Wed, 15 Nov 2023 15:07:21 +0100 [thread overview]
Message-ID: <c4c4c836-7423-4785-8489-f01e118129a4@suse.de> (raw)
In-Reply-To: <87o7fvnmn0.fsf@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On 11/15/23 14:58, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> On 11/1/23 18:09, Tom Tromey wrote:
>>> +gdb_assert {[dict get $locals namedVariables] == 3} "two locals"
>
> Tom> This fails for me with gcc 7.5.0:
> Tom> ...
> Tom> FAIL: gdb.dap/ada-nested.exp: two locals
> Tom> ...
>
> I see the test is misnamed :(
>
> Tom> AFAICT, the mismatch is because we have named_variables == 4 instead of 3.
>
> Can you modify this line:
>
> set refs [lindex [dap_check_request_and_response "fetch variables" \
> "variables" \
> [format {o variablesReference [i %d] count [i 3]} \
> $num]] \
> 0]
>
> to use 'i 4' after 'count', then send the gdb.log?
> That will show what the extra variables are.
Done, gdb.log.gz attached.
Thanks,
- Tom
[-- Attachment #2: gdb.log.gz --]
[-- Type: application/gzip, Size: 2956 bytes --]
next prev parent reply other threads:[~2023-11-15 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 17:09 [PATCH 0/7] Handle nested functions in DAP Tom Tromey
2023-11-01 17:09 ` [PATCH 1/7] Add two convenience methods to block Tom Tromey
2023-11-01 17:09 ` [PATCH 2/7] Add block::function_block Tom Tromey
2023-11-01 17:09 ` [PATCH 3/7] Move follow_static_link to frame.c Tom Tromey
2023-11-01 17:09 ` [PATCH 4/7] Add gdb.Frame.static_link method Tom Tromey
2023-11-01 17:17 ` Eli Zaretskii
2023-11-01 17:09 ` [PATCH 5/7] Fix a bug in DAP scopes code Tom Tromey
2023-11-01 17:09 ` [PATCH 6/7] Handle the static link in FrameDecorator Tom Tromey
2023-11-15 12:31 ` Tom de Vries
2023-11-15 13:58 ` Tom Tromey
2023-11-15 14:07 ` Tom de Vries [this message]
2023-11-15 14:58 ` Tom Tromey
2023-11-01 17:09 ` [PATCH 7/7] Update gdb.Symbol.is_variable documentation Tom Tromey
2023-11-01 17:15 ` Eli Zaretskii
2023-11-14 15:39 ` [PATCH 0/7] Handle nested functions in DAP Tom Tromey
2023-11-14 16:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4c4c836-7423-4785-8489-f01e118129a4@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).