From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by sourceware.org (Postfix) with ESMTPS id 730B4385800C for ; Wed, 2 Mar 2022 19:33:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 730B4385800C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f52.google.com with SMTP id u10so2781477wra.9 for ; Wed, 02 Mar 2022 11:33:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=VnHc8q3HOCBqvpnsPZLSjlsqQoV01LXB7FMXki/mGBI=; b=zvfuF2XELvhsp5KC6CcpD7WpcG7k1XwSaKG6AoJDj6IxGMaK2zDXslw/CahTkAcRwc 7eg8/UPTLDyKwitiuCxo82qi2n5x73dRj/TyWDuFxtMbAaoJJYmynIarPyC4i1beDr8e 8oNreesuxhgFkTa7vSLTTjFWP7C21zfLmgzmmuRlIlbjlLCWIfshI/ds9QD40FOJX8yv sdVjuEm3XAKESD6WO4Ub34JpOYJNl/2LeOP0DVjfSLZpwwFXHobebYXMoBsx0Bixg37Z 4P6UC4h0uswpc7xL+5RDYpJvBCTiMYciPxaFgR1sO2RS/D6fhvMUhWKf4EluAuadGhZ3 4kUg== X-Gm-Message-State: AOAM533oHkxc6xks6RNFCPNM/DnFlCQuqv8p2yFgEBVgwFG7pDGW8EiO FwWACm5KYWnOVwFNZpXHtTW6XRqFrcI= X-Google-Smtp-Source: ABdhPJzTExAStcavahlx8S4KRmzs7bIAIW+EwpQ1C/+hzuhGsRlUC9DbUfRzcORWi+gW8f4vA02Rmw== X-Received: by 2002:a5d:47cf:0:b0:1ef:faf3:d401 with SMTP id o15-20020a5d47cf000000b001effaf3d401mr9128097wrc.644.1646249603443; Wed, 02 Mar 2022 11:33:23 -0800 (PST) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id o6-20020a5d6846000000b001f044a8e214sm2147566wrw.107.2022.03.02.11.33.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 11:33:22 -0800 (PST) Message-ID: Date: Wed, 2 Mar 2022 19:33:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 09/11] gdb/testsuite: don't test gdb.base/msym-bp-shl with clang Content-Language: en-US To: Bruno Larsen , gdb-patches@sourceware.org References: <20220126195053.69559-1-blarsen@redhat.com> <20220126195053.69559-10-blarsen@redhat.com> From: Pedro Alves In-Reply-To: <20220126195053.69559-10-blarsen@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 19:33:25 -0000 On 2022-01-26 19:50, Bruno Larsen via Gdb-patches wrote: > Clang will optimize away the static function in one of the files, and > the test is here to specifically test GDB's behavior when that function > is present, so it makes no sense to have this test run with that > compiler. Please expand this info to include a snippet of the failing test. Also, it's best if the the body of the commit log, doesn't assume the subject is read as part of it. You will notice that if you read the body in isolation, without the subject line, and also without the diff context, the commit log is vague as is. > --- > gdb/testsuite/gdb.base/msym-bp-shl.exp | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/msym-bp-shl.exp b/gdb/testsuite/gdb.base/msym-bp-shl.exp > index 42adcb191dd..95d5c393505 100644 > --- a/gdb/testsuite/gdb.base/msym-bp-shl.exp > +++ b/gdb/testsuite/gdb.base/msym-bp-shl.exp > @@ -22,6 +22,13 @@ if {[skip_shlib_tests]} { > return 0 > } > > +# clang will optimize away the static foo, making a single breakpoint > +# so there is no point testing it here. Uppercase Clang. The patch doesn't give enough info to understand why this is the best approach. I could imagine using atttribute used to make sure the function isn't optimized away, as alternative approach, for example. Please make the case for the approach taken. > +if {[test_compiler_info {clang-*-*}]} { > + untested "clang only compiles one foo" > + return > +} > + > standard_testfile msym-bp-shl-main.c msym-bp-shl-main-2.c msym-bp-shl-lib.c > set srcfile ${srcdir}/${subdir}/${srcfile} > set srcfile2 ${srcdir}/${subdir}/${srcfile2}