From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id BE34A3858D34
 for <gdb-patches@sourceware.org>; Fri,  3 Jul 2020 00:31:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BE34A3858D34
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 5534F1E5F9;
 Thu,  2 Jul 2020 20:31:46 -0400 (EDT)
Subject: Re: [PATCH v4 1/2] guile: Add support for Guile 2.2.
To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= <ludo@gnu.org>, gdb-patches@sourceware.org
References: <87v9jbi855.fsf@gnu.org> <20200628142540.11320-1-ludo@gnu.org>
From: Simon Marchi <simark@simark.ca>
Message-ID: <c582adaf-b260-3fa1-bfa1-8870efedebc1@simark.ca>
Date: Thu, 2 Jul 2020 20:31:45 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200628142540.11320-1-ludo@gnu.org>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jul 2020 00:31:47 -0000

On 2020-06-28 10:25 a.m., Ludovic Courtès wrote:
> This primarily updates code that uses the I/O port API of Guile.

I know nothing about Guile, so I just scanned the patch for any obvious
red flags, but didn't see any.  The mess of #if statements sure is not
the best, but I don't have a concrete suggestion to make it better.

Simon