From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5C8083858D35 for ; Tue, 23 Apr 2024 01:38:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C8083858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C8083858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713836295; cv=none; b=R06HKGp7MIh2JLqcmnZmxYVoI331h5TBF0gGkvDMsCKd1KluNldLWn7VfO281tV6vYpjBWR9NMneFwc0pClFFsqa5KKQaibmhGNBXG6L4zC1YH5MjULfE6bzaUQDFB5Dks4Sxu199nbepPf3QOkkMxRmQm4T8UjUbC3chdgo9zg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713836295; c=relaxed/simple; bh=r72LAGIcxMTYgmC9bV+7at4m766g7+j9xP9P+gjYhbo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=oQqXIe26a2kzOfZni7mvet86OiFvmH6aUPiAp0tFjt+xKskwrUSQ3EP2SSH3fUlZVYQC/ZLzuPxc47Dw/VN7I02//n4+/fNIAvYTir9RcNfAEpNfhfoApdeT7o7QKffHH+NgelvV4TN2IVKe4awc0y4SY8y8k4at4X32Gif8VTk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1713836292; bh=r72LAGIcxMTYgmC9bV+7at4m766g7+j9xP9P+gjYhbo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=fjKjfTE2AxTE5b2KVVBQnKPStGy++INyG0eIliBEKxikhCxaqUTZnTIYRiK/b1/4E ctLtv4bb/aPamwgSAhkec7rZevrfQgJq5stK+5b96XRPtwbt/3z1KC8+V3O1Xotc72 FhpgFjvlqgUoA//kIbbBJo2IGX7mCDGdGv0evLoI= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 96F021E030; Mon, 22 Apr 2024 21:38:12 -0400 (EDT) Message-ID: Date: Mon, 22 Apr 2024 21:38:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] First cleanup of defs.h To: John Baldwin , Simon Marchi , gdb-patches@sourceware.org References: <20240422201157.46375-1-simon.marchi@efficios.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-22 18:55, John Baldwin wrote: > On 4/22/24 1:10 PM, Simon Marchi wrote: >> Here is a first batch of patches that remove things from defs.h, trying >> to sort them in more appropriate places. >> >> Simon Marchi (7): >> gdb: move two declarations out of defs.h >> gdb: move `enum compile_i_scope_types` to compile/compile.h >> gdb: remove extract_long_unsigned_integer >> gdb: move store/extract integer functions to >> extract-store-integer.{c,h} >> gdb: move RequireLongest to gdbsupport/traits.h >> gdb: don't include hashtab.h in defs.h >> gdb: don't include gdbsupport/array-view.h in defs.h > > These all look ok to me. > > Approved-By: John Baldwin > Thanks, pushed. Simon