From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11054 invoked by alias); 31 May 2019 14:42:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10995 invoked by uid 89); 31 May 2019 14:42:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:694, department X-HELO: mail-wr1-f42.google.com Received: from mail-wr1-f42.google.com (HELO mail-wr1-f42.google.com) (209.85.221.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 May 2019 14:42:00 +0000 Received: by mail-wr1-f42.google.com with SMTP id l2so6692887wrb.9 for ; Fri, 31 May 2019 07:41:59 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id t14sm8097433wrr.33.2019.05.31.07.41.57 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 07:41:57 -0700 (PDT) Subject: Re: [RFAv4 0/5] Implement | (pipe) command. To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20190530142106.25487-1-philippe.waroquiers@skynet.be> From: Pedro Alves Message-ID: Date: Fri, 31 May 2019 14:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190530142106.25487-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00751.txt.bz2 On 5/30/19 3:21 PM, Philippe Waroquiers wrote: > Implement | (pipe) command. > > This patch series adds the pipe command, that allows to send the output > of a GDB command to a shell command. > > This is the fourth version of the patch, handling the additional > comments of Pedro. > The doc, help and NEWS are changed in this fourth version, so must be > re-reviewed. This version looks good to me, apart for the comment I sent about NEWS. >From the nit department, in the testcase patch, in the last test, use lowercase for "Delimiter" in the test message. With those fixed, this is good to go. Please push. Thanks for doing this. Pedro Alves