From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id F25363858C20 for ; Mon, 28 Aug 2023 20:38:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F25363858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 37SKc2tR011511 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Aug 2023 16:38:06 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 37SKc2tR011511 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1693255086; bh=jepWLwKRJRyDMoV/E3i77ZH9HlEKWuns5dj5R4XcSUI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=MJyIyypv/LIkG0NSAN+XelvngO1ldY2nRa7DKYh21VecD89B7GnvGNaKw3ZOxQaCS 9P/TJsJogXIIGY+rzMrT41YtTx06ya1E4VOzyCfpWNxK0oQuWiemY1nR8Px6QieQk4 56ePfpkV7hcBGvgb+hcM4uafcNK6FLc4XJMcvz/s= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C60891E028; Mon, 28 Aug 2023 16:38:01 -0400 (EDT) Message-ID: Date: Mon, 28 Aug 2023 16:38:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 14/15] x86: Remove X86_XSTATE_SIZE and related constants. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-15-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20230714155151.21723-15-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 28 Aug 2023 20:38:02 +0000 X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/14/23 11:51, John Baldwin wrote: > --- > gdbsupport/x86-xstate.h | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/gdbsupport/x86-xstate.h b/gdbsupport/x86-xstate.h > index 27fc0bd12f2..40963bda55b 100644 > --- a/gdbsupport/x86-xstate.h > +++ b/gdbsupport/x86-xstate.h > @@ -99,11 +99,6 @@ constexpr bool operator!= (const x86_xsave_layout &lhs, > > #define X86_XSTATE_SSE_SIZE 576 > #define X86_XSTATE_AVX_SIZE 832 > -#define X86_XSTATE_BNDREGS_SIZE 1024 > -#define X86_XSTATE_BNDCFG_SIZE 1088 > -#define X86_XSTATE_AVX512_SIZE 2688 > -#define X86_XSTATE_PKRU_SIZE 2696 > -#define X86_XSTATE_MAX_SIZE 2696 > > > /* In case one of the MPX XCR0 bits is set we consider we have MPX. */ > @@ -112,13 +107,6 @@ constexpr bool operator!= (const x86_xsave_layout &lhs, > #define HAS_AVX512(XCR0) (((XCR0) & X86_XSTATE_AVX512) != 0) > #define HAS_PKRU(XCR0) (((XCR0) & X86_XSTATE_PKRU) != 0) > > -/* Get I386 XSAVE extended state size. */ > -#define X86_XSTATE_SIZE(XCR0) \ > - (HAS_PKRU (XCR0) ? X86_XSTATE_PKRU_SIZE : \ > - (HAS_AVX512 (XCR0) ? X86_XSTATE_AVX512_SIZE : \ > - (HAS_MPX (XCR0) ? X86_XSTATE_BNDCFG_SIZE : \ > - (HAS_AVX (XCR0) ? X86_XSTATE_AVX_SIZE : X86_XSTATE_SSE_SIZE)))) > - > /* Initial value for fctrl register, as defined in the X86 manual, and > confirmed in the (Linux) kernel source. When the x87 floating point > feature is not enabled in an inferior we use this as the value of the > -- > 2.40.0 > Approved-By: Simon Marchi Simon