From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v3] gdb/python: add a 'connection_num' attribute to Inferior objects
Date: Fri, 14 May 2021 09:15:28 -0400 [thread overview]
Message-ID: <c634ad6e-4eb7-6ee9-49cb-c63509bf4574@polymtl.ca> (raw)
In-Reply-To: <48cb6bfb672cfe5f175beda955b478c557bb2752.1620987564.git.tankut.baris.aktemur@intel.com>
On 2021-05-14 6:21 a.m., Tankut Baris Aktemur wrote:
> Define a 'connection_num' attribute for Inferior objects. The
> read-only attribute is the ID of the connection of an inferior, as
> printed by "info inferiors". In GDB's internal terminology, that's
> the process stratum target of the inferior. If the inferior has no
> target connection, the attribute is None.
>
> gdb/ChangeLog:
> 2021-05-14 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
>
> * python/py-inferior.c (infpy_get_connection_num): New function.
> (inferior_object_getset): Add a new element for 'connection_num'.
> * NEWS: Mention the 'connection_num' attribute of Inferior objects.
>
> gdb/doc/ChangeLog:
> 2021-05-14 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
>
> * python.texi (Inferiors In Python): Mention the 'connection_num'
> attribute.
>
> gdb/testsuite/ChangeLog:
> 2021-05-14 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
>
> * gdb.python/py-inferior.exp: Add test cases for 'connection_num'.
LGTM, thanks.
Simon
prev parent reply other threads:[~2021-05-14 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 10:21 Tankut Baris Aktemur
2021-05-14 13:15 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c634ad6e-4eb7-6ee9-49cb-c63509bf4574@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).