From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 077B6393A427 for ; Fri, 14 May 2021 13:15:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 077B6393A427 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14EDFTgn028350 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 May 2021 09:15:34 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14EDFTgn028350 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 53E391E783; Fri, 14 May 2021 09:15:29 -0400 (EDT) Subject: Re: [PATCH v3] gdb/python: add a 'connection_num' attribute to Inferior objects To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <48cb6bfb672cfe5f175beda955b478c557bb2752.1620987564.git.tankut.baris.aktemur@intel.com> From: Simon Marchi Message-ID: Date: Fri, 14 May 2021 09:15:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <48cb6bfb672cfe5f175beda955b478c557bb2752.1620987564.git.tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 14 May 2021 13:15:29 +0000 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 13:15:52 -0000 On 2021-05-14 6:21 a.m., Tankut Baris Aktemur wrote: > Define a 'connection_num' attribute for Inferior objects. The > read-only attribute is the ID of the connection of an inferior, as > printed by "info inferiors". In GDB's internal terminology, that's > the process stratum target of the inferior. If the inferior has no > target connection, the attribute is None. > > gdb/ChangeLog: > 2021-05-14 Tankut Baris Aktemur > > * python/py-inferior.c (infpy_get_connection_num): New function. > (inferior_object_getset): Add a new element for 'connection_num'. > * NEWS: Mention the 'connection_num' attribute of Inferior objects. > > gdb/doc/ChangeLog: > 2021-05-14 Tankut Baris Aktemur > > * python.texi (Inferiors In Python): Mention the 'connection_num' > attribute. > > gdb/testsuite/ChangeLog: > 2021-05-14 Tankut Baris Aktemur > > * gdb.python/py-inferior.exp: Add test cases for 'connection_num'. LGTM, thanks. Simon