From: Simon Marchi <simon.marchi@polymtl.ca>
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/8] testsuite: extend nopie handling to add -fno-pie to compiler flags
Date: Tue, 2 Mar 2021 11:00:17 -0500 [thread overview]
Message-ID: <c6b469bf-515f-8b79-c53d-4e9bca3ccb08@polymtl.ca> (raw)
In-Reply-To: <20210204081037.3712162-3-markus.t.metzger@intel.com>
On 2021-02-04 3:10 a.m., Markus Metzger via Gdb-patches wrote:> Some older GCC, e.g. 7.5.0 on Ubuntu 18.04 need -fno-pie to be passed to
> the compiler in addition to -no-pie to be passed to the linker for non-pie
> code generation.
>
> The gdb,nopie_flag is already documented as getting passed to the
> compiler, not the linker. Use that for the new -fno-pie compiler flag and
> add a new gdb,nopie_ldflag for the existing -no-pie linker flag.
Ok, so this changes the meaning of gdb,nopie_flag. It previously
contained linker flags and now contains compiler flags. So if someone
was using gdb,nopie_flag in their board file, they should change it to
gdb,nopie_ldflag. Perhaps make that clear in the commit message?
I don't know if we guarantee strict backwards compatibility for board
file definitions, I don't think so. We just don't change it just for
fun. In this case I think it's beneficial, because it brings it in line
with gdb,pie_flag and gdb_pie_ldflag.
So as far as I'm concerned, this patch LGTM.
Simon
next prev parent reply other threads:[~2021-03-02 16:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:10 [PATCH 0/8] pass gdb.btrace with clang Markus Metzger
2021-02-04 8:10 ` [PATCH 1/2] gdb, btrace: fix hang when stepping over a breakpoint at the end of the trace Markus Metzger
2021-02-04 8:10 ` [PATCH 1/8] testsuite: extend nopie handling to add -fno-pie to compiler flags Markus Metzger
2021-03-02 16:00 ` Simon Marchi [this message]
2021-03-03 7:57 ` Metzger, Markus T
2021-02-04 8:10 ` [PATCH] testsuite: note on use_gdb_stub usage Markus Metzger
2021-02-26 7:48 ` Metzger, Markus T
2021-02-04 8:10 ` [PATCH 2/2] gdb, record: move no-history notification into normal_stop Markus Metzger
2021-02-04 8:10 ` [PATCH 2/8] testsuite, gdb.btrace: remove assembly-check in delta.exp Markus Metzger
2021-02-04 8:10 ` [PATCH 3/8] testsuite, gdb.btrace: pass rn-dl-bind.exp with clang Markus Metzger
2021-02-04 8:10 ` [PATCH 4/8] testsuite, gdb.btrace: move -Wl,-x to ldflags Markus Metzger
2021-02-04 8:10 ` [PATCH 5/8] testsuite, gdb.btrace: adjust expected output to pass with clang Markus Metzger
2021-02-04 8:10 ` [PATCH 6/8] testsuite, gdb.btrace: remove implicit debug option in stepi.exp Markus Metzger
2021-02-04 8:10 ` [PATCH 7/8] testsuite, gdb.btrace: adjust expected source line in non-stop.exp Markus Metzger
2021-02-04 8:10 ` [PATCH 8/8] gdb, testsuite: enforce lazy binding for gdb.btrace/rn-dl-bind.exp Markus Metzger
2021-02-26 7:50 ` [PATCH 0/8] pass gdb.btrace with clang Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6b469bf-515f-8b79-c53d-4e9bca3ccb08@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).