From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 23362386100E for ; Tue, 2 Mar 2021 16:00:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23362386100E Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 122G0INj016197 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 Mar 2021 11:00:22 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 122G0INj016197 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E28E51E789; Tue, 2 Mar 2021 11:00:17 -0500 (EST) Subject: Re: [PATCH 1/8] testsuite: extend nopie handling to add -fno-pie to compiler flags To: Markus Metzger , gdb-patches@sourceware.org References: <20210204081037.3712162-1-markus.t.metzger@intel.com> <20210204081037.3712162-3-markus.t.metzger@intel.com> From: Simon Marchi Message-ID: Date: Tue, 2 Mar 2021 11:00:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210204081037.3712162-3-markus.t.metzger@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 2 Mar 2021 16:00:18 +0000 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2021 16:00:28 -0000 On 2021-02-04 3:10 a.m., Markus Metzger via Gdb-patches wrote:> Some older GCC, e.g. 7.5.0 on Ubuntu 18.04 need -fno-pie to be passed to > the compiler in addition to -no-pie to be passed to the linker for non-pie > code generation. > > The gdb,nopie_flag is already documented as getting passed to the > compiler, not the linker. Use that for the new -fno-pie compiler flag and > add a new gdb,nopie_ldflag for the existing -no-pie linker flag. Ok, so this changes the meaning of gdb,nopie_flag. It previously contained linker flags and now contains compiler flags. So if someone was using gdb,nopie_flag in their board file, they should change it to gdb,nopie_ldflag. Perhaps make that clear in the commit message? I don't know if we guarantee strict backwards compatibility for board file definitions, I don't think so. We just don't change it just for fun. In this case I think it's beneficial, because it brings it in line with gdb,pie_flag and gdb_pie_ldflag. So as far as I'm concerned, this patch LGTM. Simon