From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EED723858C50 for ; Fri, 10 Feb 2023 02:24:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EED723858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 94D741E110; Thu, 9 Feb 2023 21:24:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675995845; bh=Cw+X8E2Lbx1srBd9Y4Bo0PLrwrXRlYYMdAad2OFiFRE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=veUClOHoK7hKvL7fxwx8gVA+UneoSBPNidLXo9acncTndIF2eJwPz2IfelhObC4TA 5QnpRpjrFxoYTkQSobEEnUj50tW4mWgEB1dUVNm5MmJH1LGL6zql0LOQAwIsJXtEoR r3Fs2mp7oUyj7/aoMK1kI1Xm+kXpBmUKiLyu4VRY= Message-ID: Date: Thu, 9 Feb 2023 21:24:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 33/47] Turn remaining value_contents functions into methods Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230209-submit-value-fixups-2023-v1-0-55dc2794dbb9@tromey.com> <20230209-submit-value-fixups-2023-v1-33-55dc2794dbb9@tromey.com> From: Simon Marchi In-Reply-To: <20230209-submit-value-fixups-2023-v1-33-55dc2794dbb9@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gdb/value.h b/gdb/value.h > index 2d1c489e245..7b034bba1e2 100644 > --- a/gdb/value.h > +++ b/gdb/value.h > @@ -282,7 +282,7 @@ struct value > > When we store the entire object, `enclosing_type' is the run-time > type -- the complete object -- and `embedded_offset' is the offset > - of `type' within that larger type, in bytes. The value_contents() > + of `type' within that larger type, in bytes. The ->contents() > macro takes `embedded_offset' into account, so most GDB code I randomly spotted this oddity, "->contents()". I think there are other instances too. Also, it still talks about a macro... that could probably be updated while at it. Simon