Re: [PATCH] sim: ppc: use silent build rules here too

[will schmidt <will_schmidt@vnet.ibm.com>]

On Tue, 2021-11-02 at 23:07 -0400, Mike Frysinger wrote:
> On 02 Nov 2021 18:58, will schmidt wrote:
> > On Sun, 2021-10-31 at 05:27 -0400, Mike Frysinger via Gdb-patches
> > wrote:
> > > The ppc codebase is unique and doesn't leverage common/, so have
> > > to
> > > add silent rules to it specifically.
> > 
> >   I may have evidence to the contrary.  :-)   I don't see any
> > changes
> > here or in the recent patches that I can specifically identify as
> > troublesome, but something seems fishy between sim/ppc/libsim.a and
> > sim/common/libcommon.a ;      I'm seeing this error during recent
> > build
> > attempts on ppc64le, sometime since late last week. 
> 
> this patch is unrelated to any link failures like this

Hi, 
Agree.. I don't see anything obvious.  Just the combination of sim and
ppc and common catch my eye and seem to be the involved pieces.  A bit
more below.

> 
> > /home/willschm/install/bin/ld:
> > ../sim/ppc/libsim.a(callback.o):(.toc+0x10): undefined reference to
> > `cb_init_errno_map'
> > /home/willschm/install/bin/ld:
> > ../sim/ppc/libsim.a(callback.o):(.toc+0x18): undefined reference to
> > `cb_init_signal_map'
> > /home/willschm/install/bin/ld:
> > ../sim/ppc/libsim.a(callback.o):(.toc+0x20): undefined reference to
> > `cb_init_open_map'
> 
> you've removed important details from the log ... like what program
> is
> failing to link here ?
> -mike

GDB itself, in this case.  I respun without my local patches this
morning, and still see an issue.   More context around the error is
below.

I plan to bisect back in time a bit to confirm when this was
introduced.   I believe recently, but can't prove it.  :-)

Thanks,
-Will


--><-- 

$> make

<snip>
...
make[3]: Entering directory '/home/willschm/gdb_builds/gdb/sim'
Making all in ppc
make[4]: Entering directory '/home/willschm/gdb_builds/gdb/sim/ppc'
make[4]: Leaving directory '/home/willschm/gdb_builds/gdb/sim/ppc'
make[4]: Entering directory '/home/willschm/gdb_builds/gdb/sim'
make[4]: Leaving directory '/home/willschm/gdb_builds/gdb/sim'
make[3]: Leaving directory '/home/willschm/gdb_builds/gdb/sim'
make[2]: Leaving directory '/home/willschm/gdb_builds/gdb/sim'
make[2]: Entering directory '/home/willschm/gdb_builds/gdb/gdbsupport'
make  all-am
make[3]: Entering directory '/home/willschm/gdb_builds/gdb/gdbsupport'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/home/willschm/gdb_builds/gdb/gdbsupport'
make[2]: Leaving directory '/home/willschm/gdb_builds/gdb/gdbsupport'
make[2]: Entering directory '/home/willschm/gdb_builds/gdb/gdbserver'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/willschm/gdb_builds/gdb/gdbserver'
make[2]: Entering directory '/home/willschm/gdb_builds/gdb/gdb'
  CXXLD  gdb
/usr/lib64/gcc/powerpc64le-suse-linux/11/../../../../powerpc64le-suse-linux/bin/ld: ../sim/ppc/libsim.a(callback.o):(.toc+0x10): undefined reference to `cb_init_errno_map'
/usr/lib64/gcc/powerpc64le-suse-linux/11/../../../../powerpc64le-suse-linux/bin/ld: ../sim/ppc/libsim.a(callback.o):(.toc+0x18): undefined reference to `cb_init_signal_map'
/usr/lib64/gcc/powerpc64le-suse-linux/11/../../../../powerpc64le-suse-linux/bin/ld: ../sim/ppc/libsim.a(callback.o):(.toc+0x20): undefined reference to `cb_init_open_map'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:1904: gdb] Error 1
make[2]: Leaving directory '/home/willschm/gdb_builds/gdb.ltcd97-lp4.le.Nov03_2021_0940/gdb'
make[1]: *** [Makefile:12064: all-gdb] Error 2
make[1]: Leaving directory '/home/willschm/gdb_builds/gdb.ltcd97-lp4.le.Nov03_2021_0940'
make: *** [Makefile:903: all] Error 2