From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5383A385841F for ; Thu, 24 Feb 2022 19:16:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5383A385841F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21OJG24R026804 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Feb 2022 14:16:07 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21OJG24R026804 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8988B1F0D2; Thu, 24 Feb 2022 14:16:02 -0500 (EST) Message-ID: Date: Thu, 24 Feb 2022 14:16:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v5 06/15] do_target_wait_1: Clear TARGET_WNOHANG if the target isn't async. Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org References: <20220121201631.63530-1-jhb@FreeBSD.org> <20220121201631.63530-7-jhb@FreeBSD.org> <2a4bc2e5-a7b9-a448-1988-75c53dd61c83@polymtl.ca> <8300cb6a-c0d7-a2b7-ee20-f6eabb1c7d82@polymtl.ca> <1c29b477-e34b-bab0-7430-b506a8de18c2@polymtl.ca> <05224eba-4da5-92e7-e4f4-4cb708f315c1@FreeBSD.org> <80dd9924-7c26-16dd-fccd-bc55deb42403@polymtl.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 24 Feb 2022 19:16:02 +0000 X-Spam-Status: No, score=-3033.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 19:16:11 -0000 On 2022-02-24 14:02, John Baldwin wrote: > On 2/23/22 6:46 PM, Simon Marchi wrote: >>> Thanks for digging the details up. I assumed it had something to do with >>> an initial misunderstanding I had which was that a target was always in >>> async mode vs only being in async mode when there are non-stopped >>> inferiors. Can you please include these details in your commit reverting >>> this change? (Or did you want me to push the revert? I'm happy for you >>> to do so since you did the testing and investigation.) >> >> I'm not sure I understand what you want me to add. Here's what I came >> up with, if you have suggestions of anything to add, let me know. > > This looks good to me. Thanks! > Thanks, pushed. Simon