From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0F9013857BBD for ; Fri, 15 Jul 2022 17:20:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0F9013857BBD Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-518-7EkDTGpaNma32tum-Mfyiw-1; Fri, 15 Jul 2022 13:20:35 -0400 X-MC-Unique: 7EkDTGpaNma32tum-Mfyiw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5C0B3811E76; Fri, 15 Jul 2022 17:20:35 +0000 (UTC) Received: from [10.97.116.15] (ovpn-116-15.gru2.redhat.com [10.97.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA8DF40CF8E2; Fri, 15 Jul 2022 17:20:34 +0000 (UTC) Message-ID: Date: Fri, 15 Jul 2022 14:20:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PING][PATCHv4] gdb/testsuite: modernize gdb.base/maint.exp To: Tom Tromey , Bruno Larsen via Gdb-patches References: <20220509180431.31032-1-blarsen@redhat.com> <20220629145320.25178-1-blarsen@redhat.com> <0712fd42-a733-8cce-181a-4f408206cefd@redhat.com> <87mtdapbhu.fsf@tromey.com> From: Bruno Larsen In-Reply-To: <87mtdapbhu.fsf@tromey.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 17:20:44 -0000 On 7/15/22 13:49, Tom Tromey wrote: >>> gdb.base/maint.exp was using several gdb_expect statements, probably >>> because this test case predates the existance of gdb_test_multiple. This >>> commit updates the test case to use gdb_test_multiple, making it more >>> resilient to internal errors and such. >>> The only gdb_expect left in the testcase is one that specifically >>> looks >>> for an internal error being triggered as a PASS. > > Thank you. I think this is ok. thanks! Pushed Cheers! Bruno Larsen > > Tom >