Re: [PATCH 1/2] gdb/testsuite: tweak compiler flag handling in jit-elf-helpers.exp

[Simon Marchi <simark@simark.ca>]

On 2020-06-16 7:45 a.m., Mihails Strasuns via Gdb-patches wrote:
> db/testsuite/ChangeLog:
> 2020-06-16  Mihails Strasuns  <mihails.strasuns@intel.com>
> 
> 	* lib/jit-elf-helpers.exp (compile_jit_elf_main_as_so): Remove
> 	unused $options parameter.
> 	(compile_and_download_n_jit_so): Add optional parameter for
> 	specifying extra compiler flags.
> 	* gdb.base/jit-elf-so.exp: Do not pass compiler flag argument,
> 	it is already added by the proc itself.

Thanks that LGTM.  I would perhaps have added the new options argument in the next
patch, that actually uses it but... not a big deal.

Btw, just a nit.  Normally, the ChangeLog entry should just say very briefly what
changed not why, or go into explanations.  We prefer to put the longer explanation
about the change, the rationale, etc, in the commit message itself.  It's easier
to write something descriptive in prose there than in the ChangeLog entry, which,
by its nature, restricts the format.

So for the ChangeLog entry, you can be very brief, like:

 	* lib/jit-elf-helpers.exp (compile_jit_elf_main_as_so): Remove
 	$options parameter.
 	(compile_and_download_n_jit_so): Add optional options parameter.
 	* gdb.base/jit-elf-so.exp: Do not pass compiler flag argument.

Simon