From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 996FD3858C35 for ; Mon, 27 Nov 2023 15:57:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 996FD3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 996FD3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701100663; cv=none; b=exk3/IfDPFVmSDPfrONOKAAhXNh0wRToeSh+OlIgiwvk3xMej60iREygYSkwrl5Sizq8Gfv4k1il/dqfSzUxTcE9ed6WDqR/NpU1mVItg9kLBV+MfrdxiiPyABR61C8Wem9CS0vnuyjpOT4fzL+wVZBqL9r+kX7/oxWdziYtgWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701100663; c=relaxed/simple; bh=QxLTsQmt6J5KzeyZ+RDHFpwDffgE++eVUNlDgaTJYu0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vQGCi/7RiVTJ2tQWTBWEN59FF5L9ZyTufibZ2Pb49lT0+zWT23Si599f1UZbJVvrFQGryePh5Gl7fm4c7ZKBZ7+JCWNgtqwMAzfWywd/eJSOWZJ1ndP6EJtSEi62j93uO+BhEcCPU0nUlU1TzND7cuOp57argVn+yo34QRwagZU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1701100661; bh=QxLTsQmt6J5KzeyZ+RDHFpwDffgE++eVUNlDgaTJYu0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DHbPw6VR0DEV/ESZQextlYLqqRIOBm/akCzjYS43XAV1ogkGrDToYkxGX5ikcyVCb DADV7gNdo8ad5GKup+wj98XlulH6FvZBOZCamXhNxJ9hz+iiFcsVdSnn10Rb0bcpNH j2RBGUkAUG/wzOAvGlJigEloNgN8JdIsdSGFlBD8= Received: from [172.16.0.146] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9B8C01E091; Mon, 27 Nov 2023 10:57:40 -0500 (EST) Message-ID: Date: Mon, 27 Nov 2023 10:57:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/24] gdb: add missing raw register read in aarch64_sme_pseudo_register_write Content-Language: fr To: Luis Machado , Simon Marchi , gdb-patches@sourceware.org Cc: John Baldwin , Andrew Burgess References: <20231124212656.96801-1-simon.marchi@efficios.com> <20231124212656.96801-21-simon.marchi@efficios.com> <32824aa1-c550-48f6-b353-f166890c857d@arm.com> From: Simon Marchi In-Reply-To: <32824aa1-c550-48f6-b353-f166890c857d@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/27/23 06:43, Luis Machado wrote: > On 11/24/23 21:26, Simon Marchi wrote: >> It seems like the intention here is to read the contents of the ZA >> register and only write part of it. However, there's no actual read of >> the ZA register, so it looks like we'll write uninitialized bytes to the >> target, for the portion of the raw register where we don't write the >> pseudo register. Add a call to raw_read to fix this. >> >> I don't know how to test this though. >> >> Change-Id: I7548240bd4324f6a3b729a1ebf7502fae5a46e9e >> Reviewed-By: John Baldwin >> --- >> gdb/aarch64-tdep.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c >> index e9f5bdd141c8..e31e4bea41fc 100644 >> --- a/gdb/aarch64-tdep.c >> +++ b/gdb/aarch64-tdep.c >> @@ -3337,6 +3337,7 @@ aarch64_sme_pseudo_register_write (struct gdbarch *gdbarch, >> /* Fetch the contents of ZA. */ >> size_t svl = sve_vl_from_vq (tdep->sme_svq); >> gdb::byte_vector za (std::pow (svl, 2)); >> + regcache->raw_read (tdep->sme_za_regnum, za); >> >> /* Copy the requested data. */ >> for (int chunks = 0; chunks < offsets.chunks; chunks++) > > Thanks. LGTM. > > Approved-by: Luis Machado Thanks, added the trailer. Simon