From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 0C81F3858C52 for ; Fri, 1 Apr 2022 00:07:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0C81F3858C52 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22VLwxMh007018; Fri, 1 Apr 2022 00:07:31 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com with ESMTP id 3f1tes5p0m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Apr 2022 00:07:30 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 23106YoW019313; Fri, 1 Apr 2022 00:07:30 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3f1s962k15-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Apr 2022 00:07:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iX9NKNuyd3vcdhC2kGx8tADqKd0AlteRp8Ujhg/blgyRJ3vSk4v+1GAk51tQOgO3CHDhpR5MWTN1TdD9EvuqUBdg0WMeW0SRAi/3OhjElSgKbOp0upjslgx3CQKTUdJXI0vSp61VJEJOY8zlnRQW9N2VI7urOX15rIBviXTZl8jn4fR98KjdWSlrILjOFogCbSp2hZ5PbZdKWQ7g/1oOLmFGpcAkqMQ9Y4ZxC5juzizz9vefNJBYWdvvO8tK8HqUOCRdXKVBA2fQJxPxe+wLNE6hRZd9XYoOdL0PsMj4B0QFD3FgWoYjFCSaqubBhWffpDAW5oXseR+s1uZ767ZyNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X0Y6DM95O2Pq8SXja0cTY8vlzUxwZ2yK29o54PN5CLE=; b=Qh66EzHv9B4ZRaRR2UrCAxUo+RH7ZPMQnK/n0mmAj29Z46JfWyClnhJ1mUTzZy5HsGKBXbBYzQ8knw2cI2inBBSdAKi3OzP7dxWOqBkkxsB6VrkAFZ7nf8CgMXEOsAISew5hm7Cj8TzPo97nLTs3R2DjbzE4zSdn1zzUkWj86e6yUO1e44YZKWbSMnMI4KPNmtfbloOHlQHGecXpqY2d1BG98O5fnmDaWW6gTxapK+oklkKRp93o+qgFOXmTzPnrHBJMtV28AbqTrMqqyKIcmH0EGAObcdGJsRpJMJCoAliP/e6hs2EoTThWvf1Q4KX7eFTV3N/DXNstfw+q01KrNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SJ0PR10MB4655.namprd10.prod.outlook.com (2603:10b6:a03:2df::23) by BN0PR10MB5157.namprd10.prod.outlook.com (2603:10b6:408:121::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.21; Fri, 1 Apr 2022 00:07:27 +0000 Received: from SJ0PR10MB4655.namprd10.prod.outlook.com ([fe80::8537:4552:d54f:e597]) by SJ0PR10MB4655.namprd10.prod.outlook.com ([fe80::8537:4552:d54f:e597%5]) with mapi id 15.20.5123.023; Fri, 1 Apr 2022 00:07:27 +0000 Message-ID: Date: Thu, 31 Mar 2022 17:07:25 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/3] gdb/ctf: pass partial symtab's filename to buildsym_compunit Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220331212019.2811099-1-simon.marchi@polymtl.ca> <20220331212019.2811099-3-simon.marchi@polymtl.ca> From: Wei-min Pan In-Reply-To: <20220331212019.2811099-3-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR05CA0010.namprd05.prod.outlook.com (2603:10b6:a03:c0::23) To SJ0PR10MB4655.namprd10.prod.outlook.com (2603:10b6:a03:2df::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 263efe6f-07e8-4d48-fd8f-08da13739b1e X-MS-TrafficTypeDiagnostic: BN0PR10MB5157:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k8hZKCwPAodrzDJoKQkBusl+zh+YSofvgTUu3Kw3RqXV+wqwpZxFZIOvYxF+EWoTBen9jmAX/qZdUnkxBmrdeA2BpkqomP3Zu3zawn1aJlByaHziDmOIkc82X/1bLZSHQsmAmeJtMDFsZGrVjefERPccmh2sFVg+VH21gUAf5Edl3vzpNAYdNrevbUxg99SYSgBxUGVk+CR8EDbBAHyq9/YjQuvWw4BDsRbv/jOU1Nl9fSJL+kjY81WHHY/zgRO36sEJpiK6cc8oPLBiMoccVypTHcD9sevKWeLsYeTL7sNUTdvjVBeeSSWWZc5qTbaa4XfYHGr939+4UHp0A2T2iysgNiKNWl19Xxe906X2LcGZoOJVH3K0yCqT3jSF9QVIs+SPjDIq5GTAr/H2FSr4HNdrsJFE4dFG2Cid9+UrC22RfGFHzj3UfXFTl7vYrlgVA514NtHhu68lUqLVAH/AKlq8qRfU082ijRsb74beKPoNfPb0VmqeVDabzdicDl7TUQfKtq0lGN6EEmPdF99edIw4afzqvz4hSwRMnknQdDeaOZXS137UG3IWwWuoxeBnw9o3e/n0QhTUsi5fJqwKIE7e1vBtzI/FKuWRnK2jxT7t6VwoT+8XTnUAFXWmFoFWea0bxXEznkyAYvi2qw6FQnDkUCsoltgWgwPmT9i3U2cCS0VelqYaAXwshoNiIVcjY3DWgGobL2dkdRwGuMEWHxbpG72crUYodQPvaGX5pM2xNVn9xt34b7k0coRJyWF3Dqv7nCvAxOIvvx6KTPcGhA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB4655.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(31696002)(86362001)(52116002)(316002)(2906002)(6512007)(38100700002)(66476007)(2616005)(6506007)(83380400001)(186003)(36756003)(5660300002)(8936002)(66946007)(8676002)(66556008)(6486002)(508600001)(31686004)(403724002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXVKVG5OblRGVERnZGtBSUtDbUNjc0h0RGNDVHk3ZTZPMmJoK29HMVRFMmpk?= =?utf-8?B?aXVpaUd2aStxbmZpZUUrNFZaOWI5c1ZtYTc4QnZhU25CcXlNazRab3I1ZEJH?= =?utf-8?B?dHRYQjlNWnVFL1Y3WG8yK2xFYk9OaVB6OGYzWFdFVndwRGFxVzVoQXR6ek1y?= =?utf-8?B?Y1JYcFhYc1E3UzlpTnRYZUU4bXB5QTc0QlRwOHVCVTNlcjJFazNBa2RGYXFH?= =?utf-8?B?UVNFdXZFTlNiYW9nNVZNdXhkTExwSWtSVFpFaUhoUktjZWhTN0ZxdHpzd0pp?= =?utf-8?B?Z1VLNzlTRTZkVWRwdjBudXpvL1lPellhUmdocVJKbXAzWDU1NGZRa2Q3a1Fz?= =?utf-8?B?ZFZ1Z0k5akpSL3NXR0MyZ3NCRG8zU3hwVDNvdW15RWhuVVlXVEQ0eWFJOEhq?= =?utf-8?B?dURZV2dhZzlCT09jb2pvMjZYbThtaXRmQVRsQVlTWU9sb25TSkdyVlFabS9n?= =?utf-8?B?STdmWHdaOFo1eFBxYzBIcnFlTHBGRjB2Rld5WXBtWVRTK0lsalYvdUl4dEFB?= =?utf-8?B?OElIaTMxV3VpZVdGQUJQbVN1N0NFQ25aSGRUQVFFMHR6SUFkaVV5SG9lcGtC?= =?utf-8?B?V3UyQlVRQWhnVkpWRFRCWGNEUTdHNFU4WXgwTmdhdkVTTWw4QmtRbGh3VHc3?= =?utf-8?B?MUZjNTRqdS9MNWlLdzZWVGZIN1d3cXQ3c2RzYncwYzhBbE5aSG1BK0ZZc3JS?= =?utf-8?B?REFGcnZhU3hVUTF6ZXNmWVRmNmpQZnlWa3hjYzhxbHlYWEwrVU9URldBeFhw?= =?utf-8?B?aWYzaUZ0TGk1UXR1MDFiakZFQWkwVGRWYTcrb0pBdEQvVHFDODlSY1crRW9y?= =?utf-8?B?N3EwQyttc2l5bmRrcjR3UXVIZ2tkS0JLY0d3NTZuOUU4QWk0UE1aK29QKzVm?= =?utf-8?B?elpZbEhlN21uRldzYVdSaCtHN092UGJjTHVaVFFZVThOREpaZEFseWgrODQ0?= =?utf-8?B?bmxiK2NLQm5tQ25Ia2V5QXBiOVg2RWp6NTZBQzFiNEtUaFNYOXU0UGhVc1cw?= =?utf-8?B?VTR2ckwrTlVPWjEvMVY5Z0Z6M3EzWVBVTFNNdmNvS0hRdnZQQmFQYktGSDZI?= =?utf-8?B?UmVXc00zR25vYVNrcG82NmV4Wm40am90MmgyRVVIclduLzRQS0FMOVErVEda?= =?utf-8?B?WDFMamxaQlJwU3VKUVBFVGMzb0REL2lKK3ZkcnBRVW0wTGpjcmV2YmkwWTI5?= =?utf-8?B?Ukl4SzBOUjJHUnlob0NTZTkvTjBPVldTTVM1ZjBobUx1d2xidTdOd0JoVGdH?= =?utf-8?B?NWpOMVNVUXp1MG1IRDJYOGNyYWM3RnVBS0txazNKSThyVDdyTWttNk9yNUhh?= =?utf-8?B?REpnNnF4UmFjUStrR3BCNGpuOFl4WFdLWGZ1R0J1cXlvVklWQlltSFdmS2dV?= =?utf-8?B?TUJCUzhvaWFlZGdNalB4SEQ5a21GU1N6bkJQN3BhRGFKV0NIOEIrb2hkazZm?= =?utf-8?B?Q2FrSFhQRWRLMDFORXVHOVcvOWIwY25zbzRjbmV0VzJwVWkybjYyUmJWY0Jr?= =?utf-8?B?NGNReS9yZ3dGeWkrcndGNmo1WXBlVE5HQ2psOElEZkJFdVZBU0RJT3BYRFBr?= =?utf-8?B?RDRSWHhTTzEwdk5jTVZYVGNSQ3hiU1pndWVZbmhYbHpnUUY3Y2pNY2VUcmZK?= =?utf-8?B?V2lwYjRFQjBNYWc4eUtvcElYU2lIb2NiQTV3SFV5U0RkZXhxWTBYeGs4TWcw?= =?utf-8?B?cGx4S2tBbGNCYmNFdGcwRFk2RVN5M1FXQVdRVTN5Nkg3WFNUNTM0STAzMFly?= =?utf-8?B?YVB6bHdCRVhvMmdyVjRGZmE3VVlpYXZNaVMzWjcxNzkwNEE0clJWT0MzWko4?= =?utf-8?B?ckZUSDgybzhuL2J5endEdGxMOGlQaFhCeVZuNGNpNTlybTF0R01DeGRJVmY2?= =?utf-8?B?SzgxdXRod1oyaG1aRWVOd0g4Q3l4ZEpuR3ZHcmg3QXRDanRqd2dLZ1kzcnZV?= =?utf-8?B?VTd1RVdqZzZ1VVpnTWVxVWlxMlBiUVF5bCt0eUhFU1ZrRVo1WWJCdzcrRjRC?= =?utf-8?B?dzM4YzNDbDZnTmRIN2JHZGZMSFpvWk9ITWRsNTlxTVRsRm8vUERhME1BbHlE?= =?utf-8?B?R3FybW1IcmY1RllZa3k5M1NEbktiYTQrNWtFUy9tZEhuR3VJaGk4VUZqaFZ5?= =?utf-8?B?T0FJOERKdkJTN0piWWVFM3JDSEV1dlh4Ky9LNllYNUhURjZHY3pTckUwclRq?= =?utf-8?B?akR1NnI4WURQRlhWTmNyUzJSeXUzR2R2TEt6SjhqSXNhYUlGNnVMVVN6dUdl?= =?utf-8?B?c243V0ZQVlVSM09ZUXdsVk9mdG5BditKMlp2K2ZFSmU1czNpRHpoU0UrRDAx?= =?utf-8?B?YmZ5N1htWGN3Q0lWR3ZtdGpJUDVMVkY2OFlRNktYWDV2aFJQc21CMlBGYXRU?= =?utf-8?Q?G10Wut9Src8CiiAY2vh6lw+LdNTiUTH+u9VJt?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 263efe6f-07e8-4d48-fd8f-08da13739b1e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4655.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 00:07:27.2574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LyIMLvg3HjtPn/k7195LQzjqBOjZSMrNjSqcYlmpzqhFvV+yRg1BiPVgizc8yog0lhXSsBfqvY6XUbB58h4iWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5157 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.850 definitions=2022-03-31_06:2022-03-30, 2022-03-31 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203310121 X-Proofpoint-GUID: oN8pghdVmK_fH_TYcdHMGKKxv_Q0Ik6h X-Proofpoint-ORIG-GUID: oN8pghdVmK_fH_TYcdHMGKKxv_Q0Ik6h X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 00:07:47 -0000 On 3/31/2022 2:20 PM, Simon Marchi wrote: > I noticed that the CTF symbol reader passes the objfile's name to all > buildsym_compunit instances it creates. The result is that all > compunit_symtabs created have the same name, that of the objfile: > > { objfile /tmp/babeltrace-ctf/src/lib/.libs/libbabeltrace2.so.0.0.0 ((struct objfile *) 0x613000005d00) > { ((struct compunit_symtab *) 0x621000286760) > debugformat ctf > producer (null) > name libbabeltrace2.so.0.0.0 > dirname (null) > blockvector ((struct blockvector *) 0x6210003911d0) > user ((struct compunit_symtab *) (null)) > { symtab /tmp/babeltrace-ctf/src/lib/.libs/libbabeltrace2.so.0.0.0 ((struct symtab *) 0x6210003911f0) > fullname (null) > linetable ((struct linetable *) 0x0) > } > } > { ((struct compunit_symtab *) 0x621000275c10) > debugformat ctf > producer (null) > name libbabeltrace2.so.0.0.0 > dirname (null) > blockvector ((struct blockvector *) 0x621000286710) > user ((struct compunit_symtab *) (null)) > { symtab /tmp/babeltrace-ctf/src/lib/.libs/libbabeltrace2.so.0.0.0 ((struct symtab *) 0x621000286730) > fullname (null) > linetable ((struct linetable *) 0x0) > } > } > > Notice the two "name libbabeltrace2.so.0.0.0". > > Change it to pass the partial_symtab's filename instead. The output > becomes: > > { objfile /tmp/babeltrace-ctf/src/lib/.libs/libbabeltrace2.so.0.0.0 ((struct objfile *) 0x613000005d00) > { ((struct compunit_symtab *) 0x621000295610) > debugformat ctf > producer (null) > name libbabeltrace2.so.0.0.0 > dirname (null) > blockvector ((struct blockvector *) 0x6210003a15d0) > user ((struct compunit_symtab *) (null)) > { symtab /tmp/babeltrace-ctf/src/lib/.libs/libbabeltrace2.so.0.0.0 ((struct symtab *) 0x6210003a15f0) > fullname (null) > linetable ((struct linetable *) 0x0) > } > } > { ((struct compunit_symtab *) 0x621000288700) > debugformat ctf > producer (null) > name current-thread.c > dirname (null) > blockvector ((struct blockvector *) 0x6210002955c0) > user ((struct compunit_symtab *) (null)) > { symtab /home/simark/src/babeltrace/src/lib/current-thread.c ((struct symtab *) 0x6210002955e0) > fullname (null) > linetable ((struct linetable *) 0x0) > } > } > > Note that the first compunit_symtab still has libbabeltrace2.so.0.0.0 as > its name. This is because the CTF symbol reader really creates a > partial symtab named like this. It appears to be because the debug info > contains information that has been factored out of all CUs and is at the > "top-level" of the objfile, outside any real CU. So it creates a > partial symtab and an artificial CU that's named after the objfile. > > Change-Id: I576316bab2a3668adf87b4e6cebda900a8159b1b > --- > gdb/ctfread.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/ctfread.c b/gdb/ctfread.c > index 8636692e2e1b..7f7e09638a40 100644 > --- a/gdb/ctfread.c > +++ b/gdb/ctfread.c > @@ -1253,7 +1253,7 @@ ctf_start_symtab (ctf_psymtab *pst, > > ccp = &pst->context; > ccp->builder = new buildsym_compunit > - (of, of->original_name, nullptr, > + (of, pst->filename, nullptr, > language_c, text_offset); Looks good. Thanks. > ccp->builder->record_debugformat ("ctf"); > }