From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=nLxX=5C=irq.a4lg.com=research_trasio@sourceware.org>
Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154])
	by sourceware.org (Postfix) with ESMTPS id 057D23858D35
	for <gdb-patches@sourceware.org>; Thu,  5 Jan 2023 03:38:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 057D23858D35
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 6558D300089;
	Thu,  5 Jan 2023 03:38:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com;
	s=2017s01; t=1672889929;
	bh=taun2TqrPzYXTNTRgkIgTITGwyVJ00QxtG3G7fuOx1A=;
	h=Message-ID:Date:Mime-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=gi1qP9qIBTaREnlyWoCkzNcQcJK6hGRuG2DVOXMECZ3wTNWA1bF0bi6683T7Z4riP
	 HQky1Y5KpNDpgmbuWbhyT+cqSi5UpBxqk3Xz4uzBVvnxhUK3dxwEUJT0NL4gAP1kMo
	 djfDBK0gARqXB28S5JJNhfhR7mmOdeiz1DnFA01w=
Message-ID: <c7f5a23d-c5c5-def9-e40f-3103bf111c89@irq.a4lg.com>
Date: Thu, 5 Jan 2023 12:38:48 +0900
Mime-Version: 1.0
Subject: Re: [PATCH] sim: Move getopt checking inside SIM_AC_PLATFORM
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
References: <624505e8cc2a5551bef5de4e7c5fa0a0c21f3875.1672797663.git.research_trasio@irq.a4lg.com>
 <Y7Ttgh9HWAb1WwnL@vapier>
Content-Language: en-US
From: Tsukasa OI <research_trasio@irq.a4lg.com>
In-Reply-To: <Y7Ttgh9HWAb1WwnL@vapier>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>



On 2023/01/04 12:07, Mike Frysinger wrote:
> On 04 Jan 2023 02:01, Tsukasa OI wrote:
>> +dnl Determine whether we have a known getopt prototype in unistd.h
>> +dnl to make sure that we have correct getopt declaration on
>> +dnl include/getopt.h.
> 
> this comment should note that this logic is kept in sync with other
> projects like binutils/configure.ac.
> 
> otherwise lgtm, thanks
> -mike

Committed with changes you suggested (since the logic hasn't changed, I
consider this is a trivial change).

Thanks,
Tsukasa