From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 890D93858414 for ; Sat, 30 Oct 2021 02:04:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 890D93858414 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 19U23JYf026059 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Oct 2021 22:03:25 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 19U23JYf026059 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6F6651E940; Fri, 29 Oct 2021 22:03:19 -0400 (EDT) Message-ID: Date: Fri, 29 Oct 2021 22:03:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 1/2] Add a const version of gdb_argv:as_array_view Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20211020200525.122108-1-lsix@lancelotsix.com> <20211020200525.122108-2-lsix@lancelotsix.com> From: Simon Marchi In-Reply-To: <20211020200525.122108-2-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 30 Oct 2021 02:03:19 +0000 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2021 02:04:29 -0000 On 2021-10-20 16:05, Lancelot SIX via Gdb-patches wrote: > This commit adds a const versions for the gdb_argv::get and the > gdb_argv::as_array_view methods. Those methods will be used in the > following patch. > --- > gdb/utils.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/gdb/utils.h b/gdb/utils.h > index f05e6627dca..6f3a70213a4 100644 > --- a/gdb/utils.h > +++ b/gdb/utils.h > @@ -195,6 +195,11 @@ class gdb_argv > return m_argv; > } > > + const char * const * get () const > + { > + return m_argv; > + } > + > /* Return the underlying array, transferring ownership to the > caller. */ > > @@ -227,6 +232,11 @@ class gdb_argv > return gdb::array_view (this->get (), this->count ()); > } > > + gdb::array_view as_array_view () const > + { > + return gdb::array_view (this->get (), this->count ()); > + } > + > /* Append arguments to this array. */ > void append (gdb_argv &&other) > { > It might not be the goal of this particular patch, but operator[] could also gain a const version. And then many callers could be constified, from: gdb_argv argv (args); to const gdb_argv argv (args); But the patch LGTM as-is, that's more for future work. Simon