From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7B5A73858D28 for ; Sun, 27 Mar 2022 00:59:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B5A73858D28 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 22R0xXcx012910 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 26 Mar 2022 20:59:38 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 22R0xXcx012910 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 850481F0E7; Sat, 26 Mar 2022 20:59:33 -0400 (EDT) Message-ID: Date: Sat, 26 Mar 2022 20:59:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCHv2 1/3] gdb: work around prompt corruption caused by bracketed-paste-mode Content-Language: en-US To: Andrew Burgess , Simon Marchi Cc: gdb-patches@sourceware.org References: <0b46b6578a435b06af1896a8c59403a0df8dc758.1647253263.git.aburgess@redhat.com> <97d5c0ac-9771-f55e-0689-c00604861f5e@simark.ca> <20220326140234.GU1212730@redhat.com> From: Simon Marchi In-Reply-To: <20220326140234.GU1212730@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 27 Mar 2022 00:59:33 +0000 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Mar 2022 00:59:42 -0000 > Thanks for the awesome steps to reproduce! This made it super easy to > track down the problem. > > Basically the problem is that I only took readline 8+ into account > when writing the test, this spin of ubuntu is on readline 7. > > The patch below changes the test FAIL into a KFAIL, which, if you were > on readline 8 would be the best we could do. > > But given you're on readline 7, we should be able to do better, > getting this to a PASS! But that will require changes to GDB itself. > > I'd like to propose that first we merge the patch below, this removes > the FAIL, then next week I'll post a follow on patch for GDB that > should get this test PASSing for readline 7. > > Thoughts? Hi, I am fine with the patch below. Unfortunately I am not up to speed on what this issue with the prompt was, so I can't really help further. Thanks for coming back with a "fix" quickly, that helps. Just one nit in the commit message below. > commit 7a0add556420e2ef814a6cd58501a832fdb1fb90 > Author: Andrew Burgess > Date: Sat Mar 26 13:41:33 2022 +0000 > > gdb/testsuite: fix test failure when building against readline v7 > > The test added in the commit: > > commit a6b413d24ccc5d76179bab866834e11fd6fec294 > Date: Fri Mar 11 14:44:03 2022 +0000 > > gdb: work around prompt corruption caused by bracketed-paste-mode > > Was not written with readline 7 in mind, only readline 8+. Between > readline 7 and 8 the escape sequence used to disable bracketed paste > mode changed, an additional '\r' character was added to the end. In > fact, it was the addition of this '\r' character that triggered the > issue for which the above commit is part of the solution. > > Anyway, the test tries to spot the case where the output from GDB is > not perfect, but does have the above work around applied. However, > the pattern in the test assume that the problematic '\r' will be assume -> assumes Simon