From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BC8D2385771F for ; Wed, 21 Jun 2023 11:20:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC8D2385771F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687346458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bx57IUbSmmKj8j+dmuZNrVGZOehOREHNCz9D3MJFhBQ=; b=I4cctH+7xaOLuzLTasKHkkSrzdm1Nn9qAXSuVGYfhYPW8P5NmFTuJO6CuIqFKOR80ue/Zw jn4fHsCs07jPyFRWMmoo0fUtIGSAIt4IWS2Wya39sXQxC/Irr2fAojSFZ6Cxw3c4lQwaSH KvuzOyPkdbsIpgXKHoNT9NGuaqCZ8+s= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-0i150KiSNBCcXDhifkLL-A-1; Wed, 21 Jun 2023 07:20:57 -0400 X-MC-Unique: 0i150KiSNBCcXDhifkLL-A-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-763a40393d2so356708985a.1 for ; Wed, 21 Jun 2023 04:20:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687346456; x=1689938456; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bx57IUbSmmKj8j+dmuZNrVGZOehOREHNCz9D3MJFhBQ=; b=CuTpPEAi1W3BZ2aYj8kNIwU2NrcyJp6hnW+62/vbHT5TaPCfHW2T91TmZjbnZ0jLsJ z0bPcL16MRTHa3muOU+o27h9lOO77nAJMeTNIpOKOSnnnuCoRQIJIm2YOXT0aNrLwvLu Tjpqos1zT4ooA1hQmYTXRI/3KI+Em14/F3hzoTu9zORxCFKbZpo+2pdBvVglyqq4LkG2 n5P5ZkyzrVU/mMzqTCs/6FAYwOARvduYsw0gxN+WUlmLe40uQP5frB8mwb25uy3WYdIc EUI/Q1sLnY27ACOm6y3CNUYPPAJ2zW7GTEoOdKyO+1x5+yf+G/MtdGWeet8eowEYSnUR 7VzA== X-Gm-Message-State: AC+VfDywyPKpmXddJDyikYMOE1kEIaj8Y94GU7WFr6emUdrI7o7KE1nq ASaHqYL3qRyukWd6TC76iFsDrPnMlAdLn+HmYpJyY7QV7+Vyw2hfez0XoixwELEadOM28RcCe1M xLuOqLaHhfjDI4yhDFnD5EMo/4Y1sRQ== X-Received: by 2002:a05:620a:3a49:b0:75b:23a1:8314 with SMTP id sk9-20020a05620a3a4900b0075b23a18314mr13609402qkn.15.1687346456603; Wed, 21 Jun 2023 04:20:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5tSF+6guKLUmJNPsUMYRw9npTJfEkqsZfecpXlpMWkaMOrnt7alm73dApN5BcaxpgWA0cE2Q== X-Received: by 2002:a05:620a:3a49:b0:75b:23a1:8314 with SMTP id sk9-20020a05620a3a4900b0075b23a18314mr13609394qkn.15.1687346456390; Wed, 21 Jun 2023 04:20:56 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id i16-20020a05620a151000b0074df2ac52f8sm2140079qkk.21.2023.06.21.04.20.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 04:20:56 -0700 (PDT) Message-ID: Date: Wed, 21 Jun 2023 13:20:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 4/4] gdb/doc: document '+' argument for 'list' command To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20230621104545.2530552-1-blarsen@redhat.com> <20230621104545.2530552-5-blarsen@redhat.com> <838rcd5arg.fsf@gnu.org> From: Bruno Larsen In-Reply-To: <838rcd5arg.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/06/2023 13:13, Eli Zaretskii wrote: >> From: Bruno Larsen >> Cc: Bruno Larsen , >> Eli Zaretskii >> Date: Wed, 21 Jun 2023 12:45:45 +0200 >> >> The command 'list' has accepted the argument '+' for many years already, >> but this option wasn't documented either in the texinfo docs or in the >> help text for the command. This commit documents it. >> >> Reviewed-By: Eli Zaretskii >> --- >> gdb/cli/cli-cmds.c | 1 + >> gdb/doc/gdb.texinfo | 4 ++++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c >> index a966142eaea..b7cbe673985 100644 >> --- a/gdb/cli/cli-cmds.c >> +++ b/gdb/cli/cli-cmds.c >> @@ -2822,6 +2822,7 @@ and send its output to SHELL_COMMAND.")); >> List specified function or line.\n\ >> With no argument, lists ten more lines after or around previous listing.\n\ >> \"list .\" lists ten lines arond where the inferior is stopped.\n\ >> +\"list +\" lists the ten lines following a previous ten-line listing.\n\ >> \"list -\" lists the ten lines before a previous ten-line listing.\n\ >> One argument specifies a line, and ten lines are listed around that line.\n\ >> Two arguments with comma between specify starting and ending lines to list.\n\ > This part is OK. > >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index e4e374d138c..f9c3c90e16a 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -9149,6 +9149,10 @@ Stack}), this prints lines centered around that line. If no >> @code{list} command has been used and no solitary line was printed, >> it prints the lines around the function @code{main}. >> >> +@item list + >> +Same as using with no arguments, but errors out if the line is >> +past the end of the file. > But here it looks like some copy/pasta error? > No, this is the main distinguishing feature between "list" and "list +", the latter will error out if it is past the end of the file, while the former won't. -- Cheers, Bruno