From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2085.outbound.protection.outlook.com [40.107.92.85]) by sourceware.org (Postfix) with ESMTPS id 65EA83858C53 for ; Fri, 17 Jun 2022 16:38:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 65EA83858C53 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DitgXkqbOPAKB8TTm8GzTqpIZL/Icn5GBmEulFjfglVjcjOMrKg7H4UJCwJfV/gJ8EM92QL0bF+APLTlyXmnSB79K9oM4ywPhjCVeff5qYVxr5BOnNKmgZnaPNUP02YdVCybN3fjMKw7zUpcyxFKqJ/YpkUjhZ99oK7glYcucyotZ8eAA3vW65uIC2qkicL3c+Rlqsl7d3klOvmkGzfPk2IAJxoMl+kAOS0V6uXllqZytq+bOU8h/jhczuwBGx6uBt0Xg89cmqWKHi2OvtqHGztq7H0USzcvH1UMT3UhGK6vfEufgRAvvBuEVNdMQcmzBXlGKyZbLAEPvb65SUFsHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iWfLeY/UH+MXdDLwXWyzdn7+P6C5FLB4QNcJnoQTKCo=; b=jc0SAHVF4aBei4DGQxqL/W1pHZbEci+H8um5EVPbSfQ9pXN9AGiThByK18GBfYWhRR19VBkIh9l8elslQy0UkmicvERpePRy/37IZr70KouvNPRUYJCAh6LaOmMFMa4IFJVB5uAxudUion1VB0Rpj187jeRQD70SrXuE0+CEVr2yfoZX1uJnuhTNk2HzYa0mQivm7fC1xXpBHBqXn//xKv/p/JeA1dfI4bX+x4/5tt5ZxnPe/lYxKHRYGJbQryRnfK+50LlrsJzeymMgqDlTo3OG2jisCNV9gCRUPg3OxIk3hf4yqD3pkXL7I0hyc4sDmEe1drizi04cAgLHBT1iqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by DM5PR1201MB0121.namprd12.prod.outlook.com (2603:10b6:4:56::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.16; Fri, 17 Jun 2022 16:38:29 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::80e8:432c:4930:e41a]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::80e8:432c:4930:e41a%4]) with mapi id 15.20.5353.017; Fri, 17 Jun 2022 16:38:29 +0000 Message-ID: Date: Fri, 17 Jun 2022 17:38:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/3] gdb/varobj: Fix use after free in varobj Content-Language: en-US To: Andrew Burgess , Lancelot SIX via Gdb-patches Cc: lsix@lancelotsix.com References: <20220617101024.2830260-1-lancelot.six@amd.com> <20220617101024.2830260-3-lancelot.six@amd.com> <87v8szclvu.fsf@redhat.com> From: Lancelot SIX In-Reply-To: <87v8szclvu.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0326.eurprd06.prod.outlook.com (2603:10a6:20b:45b::34) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3150f215-6bb7-4f1c-ca42-08da507fcf2b X-MS-TrafficTypeDiagnostic: DM5PR1201MB0121:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R1v1qs7XnsYpKu1LzhXO0/bCeVoOXjvG8/faUTsuM0QnCId0Xqg1vCXik9PCFJWgae4WgzBSHf0OuOuAZTv5te4asOcswYlYIh/hYRYB+bG9JkHq7+9USw5ru3fVwCqEdUNAVsrT2QOVtavaIp8o3qoysRZrK1cUFL1e+9IeDlm+G3yeRX8BTZWa7q3l/F5OBx9UaWdUmzf7/sCN9C9z00worH0OshULIFFG3V8n+x++ggEhwSCTAHp2q5h7M9VKvdH+vpmCRuA2Y++kYLlg6BpQIyxPCGzebQQaiB5ibwCHtvTIKztleU6tMAqTkPly3LE/dJ9o+zpS+h3DiXMTjhDiIxmujujOviTUYB0lay+wyit9rCN38b9b1Qu+xuH8IWIKnn6nKPyC3pNhSSLryoNFVcsCvw8pRSOkq1NQpic1rPbpqbd+XXxF6X0eM9jKLZPnU6paSUI1avYqGy22o0w3gHp6g2ULSPvsBG5y4477glbufQwPZm/2KA+kBnZykOvYDompY6dUqcy3TzPMwfG5bLpFRLu9UXPIbI8lrd/egny1Y9bwWht6KtXIZE1sH8fuqcKUBZnZyLF6yeVHmQsXggOtxGUL6Qp5QF8dykd1sd6o4znOTqgkN6rsdqjqEPX53chX5ahiWcFxyddrK6DpQ0tDZN+9q/mBU0ktLMpAVOuq7QZmoAnO/tWlCzVBPMah6WBeQaxCAiRPV9YNyIi4bbk99eBjA15OAHd2YD1qmBobOkXF5wkyfzwFSPZdJG8Qdeot5nvwx2BYtXSsgdB0B8hN4CVxsWHq2MVtubzYz48wlRR1XgNYJTgafLOqnHG6wYO14gQl4nret7w6Sg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5745.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(66946007)(186003)(8676002)(31686004)(86362001)(6666004)(2616005)(5660300002)(6512007)(2906002)(26005)(4326008)(66476007)(66556008)(31696002)(6506007)(38100700002)(36756003)(8936002)(498600001)(6486002)(84970400001)(110136005)(83380400001)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDdiMkErS3ZuNS9HdktKVzY1SzBQSFVNOUxGWmVYanFaWGMxaFp1c3VwTWM3?= =?utf-8?B?SWJPbjl2NUl6RktWaUpBdzBXVEVLQ2tWQTlZT2F3dElQcWNOQUpuR0Q3d0Ft?= =?utf-8?B?cm1nRU9pYXp3a2pROWo1Z25HdWhZY0RRN0JiQlRGWWNoTmtIdXh2KzFkKzdK?= =?utf-8?B?YzlsRUNpWmUwRnltTU5UcGh4T2hTSGRwVlZLaytBdCtTazA2KzFmV0ZtTnRo?= =?utf-8?B?NmJoeDF1WDk2Z2YzdDk1NitwblprbHVhMXlsdHBqMGU1WHRETVQ0akJXTnFS?= =?utf-8?B?NzhWbFk5ZXZIMzhVVk8yQVlIcTVNcW9hSGNCR3dSd1ZUY3JBbnRDVkIxbzAy?= =?utf-8?B?QTNhbHp0ZmxITDRmM2F4STEvNHJidlBPSDUvVkNuazhSc0NIVGE2MEphUVFx?= =?utf-8?B?ekQweFJzUExoTVR6WjhGREJYejFaMWJ4dXJ3Wk0xTGtBeG9JYzAvNWlCZkVm?= =?utf-8?B?eVU5OTRQblYxR09TZGEyQlRrL0diUjFFWjBkVitkcjBIT3RtTFFydVEwWTdC?= =?utf-8?B?Y1BsaUR4MEJNTERIZWZaNzUwZ1BHUllSbDBTZlVMdmx5TEpFSlA1eEVqQVJK?= =?utf-8?B?UlNmbEVyL2h0QTBYVHU5aTZ6Z29rSVM0b3RaTmdhbm9DN0R1Nktvc3VEK3dj?= =?utf-8?B?MVByN2hRU2RJMHEva1hVN0ltWksrM29wbklzVlh3R0RiZWZpQ0Zha1JnM2tn?= =?utf-8?B?NHRsT0JyU2VCZkRjL3dXMU43Y0h3NDdoVXNmWkNITjNkNEtWVlNqTmV6SHht?= =?utf-8?B?c2lhWWZKd1VrOWdYUEVJTXhSSTZtd0NxZ2NzM0RJeXZQOFBLSFR5NkVOYXM0?= =?utf-8?B?Zm5wWlFhVS92MEx5U1RFR0Y4QVh2eWxmbzgwM2RKQjAzYWI5U1ZlNGlmQWdl?= =?utf-8?B?SXZsbGNwY3hnR2dqT2p5TXN4MDVlSzcwb3RXaGVNa3k4dnAzVk5zclZEb1Jh?= =?utf-8?B?cXdMSVJEK3h5K0Vla2ZQb2FBRHhKMWlXNmVmemZTQlJmbm1xenM5V2J6TWlr?= =?utf-8?B?alRLOEkvWEZVZzRrNDl4VGxoUkV2Zy9kb0pYbDBkMUhyYll3UUNJdjNTYzBJ?= =?utf-8?B?ME44d0REcVQ4SXBKUGxPNG04MWxHeGs1citQVVBiSEFDRHZEc3BBYUlZSjFO?= =?utf-8?B?NDcyYUVRTWhJdnZlSnU3WjlzQlVxdEEyVy9TVHFkK2pnaElOalVkNVZuQlVo?= =?utf-8?B?Y3hsWFRoU1JYSExRV0U4WnlvRVZGMEJmMXBta0ZoNWVtdmJ3RW9CMEZocXdL?= =?utf-8?B?UEFtbmx6MzRBWlJaNmlmdGFnMzA2Z3VjQWgzSWhJeFF6aVJNOTFwS0FQM0ZE?= =?utf-8?B?cE0yL25IRVVWdFUyVzJIQmRxeEE0ZS9iUXZTeXBzbXdEaW1mUGVUcGZEUGlr?= =?utf-8?B?Uk0zbFZiMXROaisvUVBWZ05MNGcyb0JhcDBXSUZnSFBlZ09BSHFPUWFBTkc1?= =?utf-8?B?Y25PT3F6MWZPVDFtdGtjSmRhMFg4dVBaL0t0MkI3Q1VBU1Z1Y0NCMEJYR0Z2?= =?utf-8?B?VkpEMHdqSGJEbHlYMDhJWi9vVmpHOEt5RGx3SlZwNXBPNVRNb1drSzRobU4v?= =?utf-8?B?YnowWGtxVDc3eU5VeEM2aUdBaDc2NngvamNwSWczcnlVTEZ5T0tVd1ZzU2s0?= =?utf-8?B?MFg3VlRkaTRnZnJxcjByU1c5SHNNN3BlNmZLK1RFK2JnUnpKMXYyRmhBUXpy?= =?utf-8?B?UDdZbzg5ZFFpY0xhS2NDV2hFS0FMcWM0NGEvbmhYUDFMV1pjVGVHYi9pQXBH?= =?utf-8?B?Mk85aER5OXdsWWJXalBzckhlNUNTUXlDbTQwRlZlTW9hRExmaEpueXdIaGNM?= =?utf-8?B?aXpXUHNSNnV3cU1KenJ1RG5nNTJoV2Y1Y0RPTk0ycGh5N1dDcEluVXo4anda?= =?utf-8?B?WDQrbGwza0h2d2JncDdMVWx3aSs0WG5IeEVGSmU0NVBRV2c1UFBZZGVTQW5y?= =?utf-8?B?a0N5cTFDUG5KdmJCU3JkU3o5SFpvR2xlckJSbTRFN3U1clBzY1hZbDArRlJR?= =?utf-8?B?NnYrNGFmSm1zNmxXQkl4ZzhBdE5QTnAzTlYrazd3b3B3cGN0WG9yRXJraFNH?= =?utf-8?B?ZHR3ZFJSS2NWVk0za2lkR3pzNStYOUlock03T242RVJ1L2Qwc0VRMzJpYjNl?= =?utf-8?B?YzErOXZ4QU5VMVo2UmFHV3ZZYWtLRzdJSHYzbXV4VGRsckRXdTk2ZHhnRDlH?= =?utf-8?B?dzVTa3dNNVM3bXRObmJ6M3JnMkd3ZUFzUzRZWHhPUFFadlJNUkFnM0hsVVFl?= =?utf-8?B?b3lERGhaZ3I0MmlJMTFxaThHY3hzQkJjUFAxclJTMUF3Y1ZBNnkwZmpoZGZW?= =?utf-8?B?eGE0K3lMWVhpaTVYdUdOMDdPblY5R0xWbFN2WUtoUXl3Y2h6OEoxUT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3150f215-6bb7-4f1c-ca42-08da507fcf2b X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2022 16:38:29.5355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G/9dD/9c+9EyWbQNbH/SrUfrwUoahErxeyuv/92fSaDLCmkPksssHAq9GcpGoFYKhsa1YbLih6HNncI4ciFfFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0121 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2022 16:38:34 -0000 Hi, Thanks for the feedbacks and spot-on comments. I'll integrate them in a V2 shortly. >> +gdb_exit >> +if { [mi_gdb_start] } { >> + return 0 >> +} > > Could/should the gdb_exit and mi_gdb_start calls be replaced with: > > if { [mi_clean_restart] } { > # Should we have an unsupported call in here maybe? > return > } > Yes, it should probably. I'll change this in the V2. This is what happens when we create a new test by copying an existing one… >> + # Floating varobj should still be valid, but out of scope at the moment. >> + mi_gdb_test "-var-update floating_local" \ >> + "\\^done,changelist=\\\[{name=\"floating_local\",in_scope=\"false\",type_changed=\"false\",has_more=\"0\"}\\\]" \ >> + "floating_local still valid but not in scope" > > For me, this test is failing, the output looks like: > > -var-update floating_local > ^done,changelist=[{name="floating_local",in_scope="invalid",has_more="0"}] > (gdb) > FAIL: gdb.mi/mi-var-invalidate-shlib.exp: in new process: floating_local still valid but not in scope (unexpected output) > > But, once the next patch is applied, the test starts to pass. So maybe > this test just needs moving into the next patch? Indeed, this part of the test should really be in the patch #2. Thanks for spotting this. > > I notice that non of the tests in either this patch, or the next one, > exercise this condition. > > Is it possible to create a test for this case? Will do. Issuing a "-var-update" after the dlclose call in the test should exercise this. I did that manually, but forgot to include it in the testcaes. Best, Lancelot.