public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove some "goto"s from parse.c
Date: Mon, 24 Apr 2023 15:33:42 -0400	[thread overview]
Message-ID: <c8d44a64-dce9-fb61-9822-ac8d5dc40f9f@simark.ca> (raw)
In-Reply-To: <20230424190403.1550146-1-tromey@adacore.com>

On 4/24/23 15:04, Tom Tromey via Gdb-patches wrote:
> parser_state::push_dollar has some unnecessary "goto"s.  Replacing
> them cleans up the code.  Regression tested on x86-64 Fedora 36.

Thanks, LGTM.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon

      reply	other threads:[~2023-04-24 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 19:04 Tom Tromey
2023-04-24 19:33 ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8d44a64-dce9-fb61-9822-ac8d5dc40f9f@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).