From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 656923858422 for ; Mon, 22 Jan 2024 19:54:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 656923858422 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 656923858422 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705953298; cv=none; b=LFFk0Mi4kXs5M/zECcGqTTy+YIF8Fwm53a4uPctIrYtE0GDMBeEhNsV0PmI63mXPIajG7Jh1uNwgqF3RGSXs6fY3sX0meWeXUMnflFqYdBoNCpPExbptbEH+EEOV8rVpY22LOH6AYbWErtgFVPiK/xTAzOO6CZFAYkad7FVl3+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705953298; c=relaxed/simple; bh=Qbs6Tv8RG2KGb0C6xhdk+L4+sfcTBdL1Dso9HT5ytpg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZKW5c7I3DL8SJ1mes0/2s+W+nfZK1CmUUCtjCvaVnCgwI5T8nAy7h87XsCMg1MtwD+UKbSvu0tcKyKj6Z+uCg9W4az88mcZ8fIe8seN2wDoLUbl832Q/qgCIYYpoR0jPq6NPuVGgYvjzErVzZ5/Gbh6M4LGiMiDTgRdkvQvWp/Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1705953297; bh=Qbs6Tv8RG2KGb0C6xhdk+L4+sfcTBdL1Dso9HT5ytpg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Lj0IkosMSN9V5giqnXqFmNhd681ZkfWRCz1fpFzZD0y9lLS9UlN6WZX0mhBqKXq2k RidWm7b6alJMCxlWuRPatDVpz4AVKbe+/JpSZntkllVINf/8HcdCXIn03Uyxh24u2j G3cW7Uw/q39uIcvCkF8o35YPFw4I9qMRlYPLDW2A= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BB8551E092; Mon, 22 Jan 2024 14:54:56 -0500 (EST) Message-ID: Date: Mon, 22 Jan 2024 14:54:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Avoid duplicate test in dw2-zero-range.exp Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240119190752.4075435-1-tromey@adacore.com> <944ca7d4-5510-4e55-9e3f-11af441a309a@simark.ca> <871qa9l8e6.fsf@tromey.com> From: Simon Marchi In-Reply-To: <871qa9l8e6.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-01-22 10:01, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> On 1/19/24 14:07, Tom Tromey wrote: >>> I noticed that dw2-zero-range.exp reports a duplicate test name. This >>> happens because have_index calls get_index_type with the default test >>> name. This patch fixes the problem using with_test_prefix. > > Simon> Hi Tom, > > Simon> I was going to point out a few things that could be cleaned up in this > Simon> test to make it more readable, but I figured I might as well do them > Simon> instead of asking you for more work. The patch below is what I came up > Simon> with. > > Seems fine to me. > > Tom Thanks, pushed. Simon