From: Simon Marchi <simon.marchi@polymtl.ca>
To: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] sim: split sim/callback.h include out
Date: Sun, 20 Jun 2021 11:11:29 -0400 [thread overview]
Message-ID: <c907a53c-faf2-53b2-b2b7-219a09d9f3be@polymtl.ca> (raw)
In-Reply-To: <20210616063302.20722-1-vapier@gentoo.org>
On 2021-06-16 2:33 a.m., Mike Frysinger via Gdb-patches wrote:
> The sim-basics.h is too big and includes too many things. This leads
> to some arch's sim-main.h having circular loop issues with defs, and
> makes it hard to separate out common objects from arch-specific defs.
> By splitting up sim-basics.h and killing off sim-main.h, it'll make
> it easier to separate out the two.
>
> Start with splitting out sim/callback.h.
Starting with this patch (according to bisect), I get this link error:
make[3]: Entering directory '/home/simark/build/binutils-gdb/sim/erc32'
ccache gcc -DHAVE_CONFIG_H -DWITH_HW=1 -DHAVE_DV_SOCKSER -DDEFAULT_INLINE=0 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -I. -I/home/simark/src/binutils-gdb/sim/erc32 -I../common -I/home/simark/src/binutils-gdb/sim/erc32/../common -I../../include -I/home/simark/src/binutils-gdb/sim/erc32/../../include -I../../bfd -I/home/simark/src/binutils-gdb/sim/erc32/../../bfd -I../../opcodes -I/home/simark/src/binutils-gdb/sim/erc32/../../opcodes -I../.. -I/home/simark/src/binutils-gdb/sim/erc32/../../gnulib/import -I../../gnulib/import -DFAST_UART -I/home/simark/src/binutils-gdb/sim/erc32/../.. -g3 -O0 -fsanitize=address -fmax-errors=1 -fdiagnostics-color=always -o sis \
sis.o exec.o erc32.o func.o help.o float.o ../common/common_libcommon_a-portability.o ../common/common_libcommon_a-sim-load.o ../common/common_libcommon_a-version.o ../../bfd/libbfd.a ../../opcodes/libopcodes.a ../../libiberty/libiberty.a -lm -ltinfo -ldl -lnsl -lz -lreadline -ltinfo -lm ../../gnulib/import/libgnu.a
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: warning: relocation against `current_target_byte_order' in read-only section `.text'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `LSEXTRACTED':
/home/simark/src/binutils-gdb/sim/common/sim-bits.c:64: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `MSEXTRACTED':
/home/simark/src/binutils-gdb/sim/common/sim-bits.c:99: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `LSINSERTED':
/home/simark/src/binutils-gdb/sim/common/sim-bits.c:134: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `MSINSERTED':
/home/simark/src/binutils-gdb/sim/common/sim-bits.c:170: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `LSSEXT':
/home/simark/src/binutils-gdb/sim/common/sim-bits.c:207: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o:/home/simark/src/binutils-gdb/sim/common/sim-bits.c:234: more undefined references to `sim_io_error' follow
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_t2h_1':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_h2t_1':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `offset_1':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:145: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:146: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:147: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_t2h_2':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_h2t_2':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `offset_2':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:145: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:146: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:147: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_t2h_4':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_h2t_4':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `offset_4':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:145: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:146: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:147: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_t2h_8':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_h2t_8':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `offset_8':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:145: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:146: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:147: undefined reference to `sim_io_error'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_t2h_16':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:47: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `endian_h2t_16':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:61: undefined reference to `current_target_byte_order'
/usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `offset_16':
/home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:145: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:146: undefined reference to `sim_io_error'
/usr/bin/ld: /home/simark/src/binutils-gdb/sim/common/sim-n-endian.h:147: undefined reference to `sim_io_error'
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE
collect2: error: ld returned 1 exit status
Simon
next prev parent reply other threads:[~2021-06-20 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 6:33 Mike Frysinger
2021-06-16 6:33 ` [PATCH 2/3] sim: drop core libiberty.h include Mike Frysinger
2021-06-16 6:33 ` [PATCH 3/3] sim: split sim-signal.h include out Mike Frysinger
2021-06-20 15:11 ` Simon Marchi [this message]
2021-06-20 20:56 ` [PATCH 1/3] sim: split sim/callback.h " Mike Frysinger
2021-06-21 17:38 ` Simon Marchi
2021-06-21 23:48 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c907a53c-faf2-53b2-b2b7-219a09d9f3be@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).