From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 06/15] Change tui_addr_is_displayed into a method
Date: Thu, 15 Aug 2019 16:28:00 -0000 [thread overview]
Message-ID: <c918c7bd-292f-9f20-2122-b658059b14aa@redhat.com> (raw)
In-Reply-To: <20190814162132.31424-7-tom@tromey.com>
On 8/14/19 5:21 PM, Tom Tromey wrote:
> diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
> index 1b2b4393fd9..e8e7061d0f2 100644
> --- a/gdb/tui/tui-winsource.c
> +++ b/gdb/tui/tui-winsource.c
> @@ -668,31 +668,3 @@ tui_line_is_displayed (int line,
>
> return is_displayed;
> }
> -
> -
> -/* Answer whether a particular line number or address is displayed
> - in the current source window. */
> -int
> -tui_addr_is_displayed (CORE_ADDR addr,
> - struct tui_source_window_base *win_info,
> - int check_threshold)
That intro comment is lost. Move it...
> --- a/gdb/tui/tui-disasm.h
> +++ b/gdb/tui/tui-disasm.h
> @@ -51,6 +51,10 @@ struct tui_disasm_window : public tui_source_window_base
> protected:
>
> void do_scroll_vertical (int num_to_scroll) override;
> +
> +private:
> + bool addr_is_displayed (CORE_ADDR addr) const;
here?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-08-15 16:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 16:21 [PATCH 00/15] Another round of TUI refactoring Tom Tromey
2019-08-14 16:21 ` [PATCH 12/15] Remove tui_initialize_static_data Tom Tromey
2019-08-14 16:21 ` [PATCH 14/15] Change TUI source window iteration Tom Tromey
2019-08-14 16:21 ` [PATCH 09/15] Turn tui_erase_source_content into a method Tom Tromey
2019-08-14 16:21 ` [PATCH 01/15] Simplify TUI boxing Tom Tromey
2019-08-14 16:21 ` [PATCH 10/15] Remove tui_clear_source_content Tom Tromey
2019-08-14 16:21 ` [PATCH 11/15] Minor simplification in tui_default_win_viewport_height Tom Tromey
2019-08-14 16:21 ` [PATCH 05/15] Move contents of tui_show_frame_info to new method Tom Tromey
2019-08-15 16:28 ` Pedro Alves
2019-08-14 16:21 ` [PATCH 02/15] Remove FIXMEs from tui-layout.c Tom Tromey
2019-08-14 16:21 ` [PATCH 15/15] TUI window resize should not need invisibility Tom Tromey
2019-08-14 16:21 ` [PATCH 08/15] Remove tui_alloc_source_buffer Tom Tromey
2019-08-14 16:21 ` [PATCH 06/15] Change tui_addr_is_displayed into a method Tom Tromey
2019-08-15 16:28 ` Pedro Alves [this message]
2019-08-14 16:21 ` [PATCH 07/15] Change tui_line_is_displayed to be " Tom Tromey
2019-08-14 16:21 ` [PATCH 03/15] Move locator code to tui-stack.c Tom Tromey
2019-08-14 16:21 ` [PATCH 13/15] Rename the "reset" method to "resize" Tom Tromey
2019-08-14 16:23 ` [PATCH 04/15] Avoid string_file in tui_make_status_line Tom Tromey
2019-08-15 16:29 ` [PATCH 00/15] Another round of TUI refactoring Pedro Alves
2019-08-15 18:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c918c7bd-292f-9f20-2122-b658059b14aa@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).