Re: [PATCH] Fix for call feature having nine parameters or more in AIX

[Ulrich Weigand <Ulrich.Weigand@de.ibm.com>]

Aditya Kamath1 <Aditya.Kamath1@ibm.com> wrote:

>Hope this looks good now. Kindly let me know. If not kindly push these changes.

Just a few comments remaining:

>+         space += ((len - argbytes + wordsize -1) & -wordsize);
Please use "- 1" instead of "-1" everywhere here.

>+         write_memory (sp + 24 + (ii * wordsize),
I think this needs to be 6 * wordsize instead of 24 here too.

>+         if (wordsize == 8 &&  
>+            (type->code () == TYPE_CODE_INT
>+             || type->code () == TYPE_CODE_ENUM
>+             || type->code () == TYPE_CODE_BOOL
>+             || type->code () == TYPE_CODE_CHAR ))
>+           {
I'm not sure the "wordsize == 8" check is correct here.  It's of course
a question of how the 32-bit AIX ABI is defined, but for parameters in
registers, we do the extension on 32-bit too.  So it seems likely to me
that we need to do it for parameters in memory as well.

Bye,
Ulrich